300399 - MDGEngine calls ValidateNode before all external schemas have loaded

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

nsXFormsModelElement::HandleEvent gets called for DOMContentLoaded, which makes
it set mDocumentLoaded to true.

nsXFormsModelElement::Revalidate() sees mDocumentLoaded is true and called
revalidate on the MDG.

Per spec, we need to wait for all schemas to load before we start binding I believe.

Comment 1

[Doron Rosenberg (IBM)]

Testcase: http://www.nexgenmedia.net/bugs/300399/test.xhtml

When you load the page, both fields will be marked invalid (red).  This is
because ValidateNode calls Schema Validation, and it finds no loaded schemas and
returns an NS_ERROR_*.

Go into the first field and remove on of the digits (or add one), and it will
change to valid (after you tab out).  The type it binds to is an integer with a
maxInclude of 10000000.

Comment 2

[aaronr]

Attachment: proposed fix

just moved the rebuild, recalculate and revalidate event generation to
nsXFormsModelElement::FinishConstruction, where steps 2, 3, and 4 from 4.2.1
live.	FinishConstruction should only be called when all of the schemas and
instance are done loading. This fix doesn't seem to cause any problems with my
testing so far.  Doron please try out with your external schema testcases.

Comment 3

[Doron Rosenberg (IBM)]

Comment on attachment 189100 [details] [diff] [review]
proposed fix

fixes the issue for me!

Comment 4

[aaronr]

Comment on attachment 189100 [details] [diff] [review]
proposed fix

Is this change going to hurt the MDG, Allan?  Doesn't seem to.

Comment 5

[Allan Beaufour]

Comment on attachment 189100 [details] [diff] [review]
proposed fix

r=me

Comment 6

[Doron Rosenberg (IBM)]

checked in.