300409 - l10n tinderboxen don't have svg+canvas

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect, P1)

Description

[Benjamin Smedberg]

The l10n tinderboxen do not have svg+canvas enabled. Plus, we should really test
the system that unpacks the en-US build and repacks it. I suggest that instead
of getting the SVG enabled we just set it up so that the trunk tinderbox pulls
down the nightly en-US build and doesn't bother tobuild ffox itself, only the
l10n repackaging.

Comment 1

[Benjamin Smedberg]

Attachment: Add configureonly and additional build vars, rev. 1 [checked in]

Comment 2

[Benjamin Smedberg]

When this patch is applied (in CVS or locally on the tinderboxen) the following
tinder-config settings are needed:

# All platforms:
$ConfigureOnly = 1;
$BuildLocales = 1; # Should already be set
@CompareLocaleDirs = ("netwerk", "dom", "security/manager", "toolkit",
"browser"); # Should already be set

# On windows
%WGetFiles = (
"http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/pacifica-trunk/firefox-1.0+.en-US.win32.installer.exe"

=>
"/cygdrive/c/<path-to-objdir>/firefox-installer.exe",

"http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/pacifica-trunk/firefox-1.0+.en-US.win32.zip"

=>
"/cygdrive/c/<path-to-objdir>/firefox.zip");

$BuildLocalesArgs = "ZIP_IN=/cygdrive/c/<path-to-objdir>/firefox.zip
WIN32_INSTALLER_IN=/cygdrive/c/<path-to-objdir>/firefox-installer.exe";

# on non-windows
%WGetFiles = (
"http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/<appropriate-tbox>/firefox-1.0+.<appropriate-file>"

=>
"/cygdrive/c/<path-to-objdir>/firefox.<extension>");

$BuildLocalesArgs = "ZIP_IN=/cygdrive/c/<path-to-objdir>/firefox.<extension>";

Comment 3

[Chase Phillips]

Comment on attachment 190961 [details] [diff] [review]
Add configureonly and additional build vars, rev. 1 [checked in]

bsu and pmr need a major workover soon but this change is a win and the final
piece for putting us exactly where I wanted us to be in bug 287262.  Thanks
bsmedberg for making this happen!

Comment 4

[Chase Phillips]

coop, for these changes first focus on chroma's Firefox trunk build then its
Thunderbird trunk build.  Re: karma and maya, you should determine the order
which works best for you.

Please note your progress per systems' build tree in this bug and make notes
about changes to system configurations in our build team wiki.

Comment 5

[Benjamin Smedberg]

Comment on attachment 190961 [details] [diff] [review]
Add configureonly and additional build vars, rev. 1 [checked in]

Tinderbox client patch checked in on trunk.

Comment 6

[Benjamin Smedberg]

Further note: there could be a better way to slurp the en-US builds than wget to
ftp.m.o (ftp-stage, or perhaps we should even scp the English files directly
from stage?)

Comment 7

[Chase Phillips]

(In reply to comment #6)
> Further note: there could be a better way to slurp the en-US builds than wget to
> ftp.m.o (ftp-stage, or perhaps we should even scp the English files directly
> from stage?)

I instructed coop to do exactly that Friday.  Best we grab them from a host in
the same colo than go out across the world for the files.

Grabbing the files via scp could be useful, although having the wget notion
helps people that are already staging builds to a web-based repository.

Comment 8

[Chris Cooper [:coop] (he/him)]

Firefox seems to be building correctly on chroma with the new wget setup:

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1122970598.25795.gz&fulltext=1

I made what I think are comparable changes to get Thunderbird building the same
way, but the Thunderbird tinderbox for chroma is orange:

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1122994404.14319.gz&fulltext=1

Is this update meant to be applied for all the l10n builds, i.e. should I be
making these changes to the Aviary builds as well?

Comment 9

[Benjamin Smedberg]

It looks like chroma tbird is orange because it is trying to do talkback
packaging. Talkback should be off for these configureonly builds.

And the aviary tinderboxen should not be changed (they don't support repackaging
at all).

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to comment #9)
> It looks like chroma tbird is orange because it is trying to do talkback
> packaging. Talkback should be off for these configureonly builds.

Toggled $shiptalkback to 0 (off), but the chroma Tb l10n build is still orange.

I've also just updated the Fx and Tb configs on maya. We should soon see whether
the wget-ing of dmg images will work correctly.

I will begin updating karma's configs shortly.

Comment 11

[Chris Cooper [:coop] (he/him)]

(In reply to comment #10)
> I will begin updating karma's configs shortly.

karma's configs have now been updated.

Comment 12

[Axel Hecht]

karma l10n builds are still red with

cat: ../../config/build_number: No such file or directory

Comment 13

[Chris Cooper [:coop] (he/him)]

(In reply to comment #12)
> karma l10n builds are still red with
> 
> cat: ../../config/build_number: No such file or directory

I see it in the logs, but is this actually causing any harm, i.e. is this what
is causing locale builds to be 'busted?'

Comment 14

[Benjamin Smedberg]

> cat: ../../config/build_number: No such file or directory

That's not a problem.

The tbird l10n builds were busted because editor/ui/locales/Makefile was missing
from allmakefiles.sh... I just checked in a fix for that.

The ffox karma l10n builds were horked because firefox.tar.gz was a malformed
tarfile... I don't know why, it may have just been a download fluke.

The maya firefox builds are busted because the custom ZIP_IN is not set in the
tinderbox config.

Comment 15

[Chris Cooper [:coop] (he/him)]

(In reply to comment #14)
> The maya firefox builds are busted because the custom ZIP_IN is not set in the
> tinderbox config.

I'm pretty sure this was set before, but I've just verified that ZIP_IN is being
set on maya:
 
$BuildLocalesArgs =
"ZIP_IN=/builds/tinderbox/Fx-Trunk-l10n/Darwin_7.9.0_Clobber/firefox.dmg";

Comment 16

[Chris Cooper [:coop] (he/him)]

The main l10n builds are all showing green now, but the individual locales are
busted.

e.g.

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-fr

On MacOS, we're getting the following error (similar error seen for Tb):

make[2]: *** No rule to make target
`/builds/tinderbox/Fx-Trunk-l10n/Darwin_7.9.0_Clobber/mozilla/dist/firefox-1.0+.en-US.mac.dmg',
needed by `repackage-zip'.  Stop.

Linux and Windows are reporting Fail or Test Failed, but there are no error
messages to speak of in their output.

Comment 17

[Benjamin Smedberg]

> The main l10n builds are all showing green now, but the individual locales are
> busted.
> 
> http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-fr

Some locales are busted because they actually *are* busted. Polish
(Mozilla-l10n-pl) is not busted, but is orange for basically the same reason
(we're not in string freeze yet, so there are going to be missing entities in
most locales). Of course, this makes it hard to tell when stuff is actually
working ;-)

> On MacOS, we're getting the following error (similar error seen for Tb):
> 
> make[2]: *** No rule to make target
>
`/builds/tinderbox/Fx-Trunk-l10n/Darwin_7.9.0_Clobber/mozilla/dist/firefox-1.0+.en-US.mac.dmg',
> needed by `repackage-zip'.  Stop.

aha! we're calling the installers-<locale> target in a different place on mac
than we are for windows/unix:
http://lxr.mozilla.org/mozilla/source/tools/tinderbox/post-mozilla-rel.pl#520
http://lxr.mozilla.org/mozilla/source/tools/tinderbox/post-mozilla-rel.pl#566

We need to add the $Settings::BuildLocalesArgs to line 566 also. I will do that
in CVS, and you can update or manually tweak the local files.

Comment 18

[Chris Cooper [:coop] (he/him)]

I've pulled the new file from CVS on maya. Indeed, locale builds are already
starting to green up:

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-fr

Comment 19

[Chris Cooper [:coop] (he/him)]

Tinderbox changes have been made. Many locale builds are already green; broken
locales are showing real bustage, i.e. it's up to localizers to fix their builds
now.

Comment 20

[Axel Hecht]

The karma aviary boxens don't run compare-locales anymore, did these config 
changes regress that?

08/05 06:42:00,
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-zh-TW/1123249320.26278.gz&fulltext=1
from
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-zh-TW&hours=24&maxdate=1123319940&legend=0
seems to be the last build that ran it.

Comment 21

[Chris Cooper [:coop] (he/him)]

(In reply to comment #20)
> The karma aviary boxens don't run compare-locales anymore, did these config 
> changes regress that?
> 
> 08/05 06:42:00,
>
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-zh-TW/1123249320.26278.gz&fulltext=1
> from
>
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-zh-TW&hours=24&maxdate=1123319940&legend=0
> seems to be the last build that ran it.


Maybe I'm confused, but the link you provided is for an Fx Trunk build, and
those continue to run compare-locales as normal. 

I've gone back as far as 2005/06/19 and haven't seen karma trying to run
compare-locales against the Aviary branch build. Should it be?

Comment 22

[Benjamin Smedberg]

Yes, it should (toolkit/locales and browser/locales only for the aviary branch).

Comment 23

[Chris Cooper [:coop] (he/him)]

(In reply to comment #22)
> Yes, it should (toolkit/locales and browser/locales only for the aviary branch).

OK, I've set karma to compare those directories for the Aviary build. Comparison
should happen in the next build cycle.

Comment 24

[Chris Cooper [:coop] (he/him)]

(In reply to comment #23)
> OK, I've set karma to compare those directories for the Aviary build. Comparison
> should happen in the next build cycle.

Axel: can you please verify that this is working the way you expect it to now?

Comment 25

[Axel Hecht]

Yes, thanks, it does. zh-TW is orange.