Closed
Bug 300411
Opened 19 years ago
Closed 19 years ago
designmode remains when going back in history with bfcache enabled with this designmode testcase
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: bryner)
References
Details
(Keywords: testcase)
Attachments
(2 files)
334 bytes,
text/html
|
Details | |
6.41 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
See upcoming testcase. -Make sure you've enabled bfcache on. -Open testcase -Go back Result: designmode is still on, while it should be off.
Reporter | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Flags: blocking1.8b4?
OS: Windows XP → All
Assignee | ||
Comment 2•19 years ago
|
||
This is actually a problem with the timing of the STATE_START notification. The editor's WebProgressListener expects the old document to still be in the window at the time the STATE_START notification is received. To make that be true for fastback, I changed things around so that we fire STATE_START for the toplevel load earlier, before we swap out the content viewer. Subframes get their STATE_START _after_ we swap out the content viewer, since in a non-fastback load we would have had to start loading data in order for a subframe to be constructed.
Assignee | ||
Updated•19 years ago
|
Assignee: adamlock → bryner
Status: NEW → ASSIGNED
Attachment #189086 -
Flags: superreview?(darin)
Attachment #189086 -
Flags: review?(darin)
Comment 3•19 years ago
|
||
Comment on attachment 189086 [details] [diff] [review] patch The call BeginRestore on each child docshell seems like it should be moved into a subroutine. Otherwise, this looks good. I might add some documentation about the new viewer parameter. r+sr=darin with those tweaks.
Attachment #189086 -
Flags: superreview?(darin)
Attachment #189086 -
Flags: superreview+
Attachment #189086 -
Flags: review?(darin)
Attachment #189086 -
Flags: review+
Assignee | ||
Comment 4•19 years ago
|
||
Oh, one more thing I'll explain because it might look like a mistake: I removed the call to Show() because this happens implicitly as part of Thaw(). PresShell::UnsuppressAndInvalidate calls mPresContext->EnsureVisible() which takes care of it.
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 189086 [details] [diff] [review] patch requesting approval. everything here is localized to fastback.
Attachment #189086 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #189086 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 6•19 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 7•19 years ago
|
||
I just tested an hourly trunk build (http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/prometheus-trunk/ Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050714 Firefox/1.0+) and this fix seems a little broken. Try this: - open http://forums.mozillazine.org/viewtopic.php?t=292151 - click on the link that links to this bug (#11: 300411) - this opens into a new window - click on the test case attachment link - press back - designmode is off which is good. However, now you can't type into the comment text area. Also, if you click on the test case attachment link, it actually opens up on the mozillazine forum window.
(In reply to comment #7) > I just tested an hourly trunk build > (http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/prometheus-trunk/ > Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050714 Firefox/1.0+) > and this fix seems a little broken. Ditto, with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050715 Firefox/1.0+ ID:2005071508 Fresh zip install, clean profile, ext's: DOMi, Reporter, Talkback, Nightly Tester Tools, winxp pro sp2. > Try this: > - open http://forums.mozillazine.org/viewtopic.php?t=292151 > - click on the link that links to this bug (#11: 300411) - this opens into a new > window I just opened this bug from the URL bar. > - click on the test case attachment link > - press back > - designmode is off which is good. However, now you can't type into the > comment text area. Or any other text area on the page. > Also, if you click on the test case attachment link, it actually > opens up on the mozillazine forum window. Don't see this. The second time clicking the test case link, I get a blank page. View-source says the source is there, undisplayed. Re-open or new bug? HTH, and isn't just spam.
Reporter | ||
Comment 9•19 years ago
|
||
I believe the issues mentioned in comment 7 and comment 8 are basically the issues left to fix in bug 287707.
Updated•19 years ago
|
Flags: blocking1.8b4?
You need to log in
before you can comment on or make changes to this bug.
Description
•