300414 - Better visual indication that extension is to be uninstalled

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b3) Gecko/20050710
Firefox/1.0+

Steps to reproduce:
1. Right-click an extension and select "uninstall".

Result: the only change is that the extension's description is replaced by "x
will be uninstalled next time you restart Firefox".  This change is easy to miss
because it only involves text and because it happens as a dialog disappears and
the next extension becomes selected.  Some users, such as my friend Selene,
momentarily think that nothing happened.

Expected: remove the icon or change the icon (?)

Comment 1

[Robert Strong (they/them - no direct email)]

The opType attribute on the extension element can be used in css for this as
well as showing other states if desired. The possible values are as follows and
are self-explanatory:
needs-install
needs-upgrade
needs-uninstall
needs-enable
needs-disable

Note: bug 299395 should probably be taken care of at the same time.

Comment 2

[Asaf Romano (gone)]

-> Kevin (see comment 1).

Comment 3

[Kevin Gerich]

fixed on branch and trunk by patch from bug 281974. I gave the extension icon an
opacity of 0.2 when it is marked for uninstall