300432 - UMR in nsCategoryManager::NotifyObservers

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Stuart Parmenter]

The checkin for bug 246085 caused this regression.

[W] UMR: Uninitialized memory read in nsCategoryManager::NotifyObservers(char
const*,char const*,char const*) {1 occurrence}
        Reading 4 bytes from 0x03506c84 (4 bytes at 0x03506c84 uninitialized)
        Address 0x03506c84 is 76 bytes into a 80 byte block at 0x03506c38
        Address 0x03506c84 points to a C++ new block in heap 0x01f30000
        Thread ID: 0x16f0
        Error location
            nsCategoryManager::NotifyObservers(char const*,char const*,char
const*) [c:\builds\mozilla\xpcom\components\nscategorymanager.cpp:526]
                void
                nsCategoryManager::NotifyObservers( const char *aTopic,
                                                    const char *aCategoryName,
                                                    const char *aEntryName )
                {
             =>   if (mSuppressNotifications)
                    return;

Comment 1

[Stuart Parmenter]

Attachment: fix

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 189010 [details] [diff] [review]
fix

seems to me like this'd fit better into a constructor, but ok..

Comment 3

[Darin Fisher]

hrm, yeah.. i agree with biesi.  why not put this initializer in the
nsCategoryManager constructor?

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #3)
> hrm, yeah.. i agree with biesi.  why not put this initializer in the
> nsCategoryManager constructor?

My patch (attachment 189593 [details] [diff] [review]) in bug 246085 includes that change.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

-> chpe, his patch in bug 246085 fixes this

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 306780 has been marked as a duplicate of this bug. ***

Comment 7

[Darin Fisher]

Now that the latest patch for bug 246085 is in, we can mark this bug FIXED.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 325863 has been marked as a duplicate of this bug. ***

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Worth noting that this is still alive on MOZILLA_1_8_0_BRANCH, which seems a bit disturbing to me.