300442 - Extensions fail to install since landing of patch for Bug 298524

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[bugzilla]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050711 Firefox/1.0+ (Swiftfox)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050711 Firefox/1.0+ (Swiftfox)

Extensions fail to install using a linux trunk build.  Any attempt to install a
compatible extension results in the extension manager opening in what appears to
be a collapsed state.  The error in the Javascript Console is:

"Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIScrollBoxObject.scrollToElement]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://global/content/bindings/richlistbox.xml :: init :: line 171"  data: no]"

This seems to have started happening when the patch for Bug 298524 landed.  This
doesn't affect the prometheus trunk builds but I am able to reproduce it in my
builds.  I tried a vanilla build with no extra patches or optimizations and the
problem still exists.  I have also verified that by backing out the change to
toolkit/mozapps/extensions/content/extensions.js from Bug 298524 that extensions
install correctly again.  

Reproducible: Always

Steps to Reproduce:
1.Download a linux trunk build from http://getswiftfox.com
2.Attempt to install an extension
3.

Actual Results:  
Extension installation failed.

Expected Results:  
Extension should have installed successfully.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Check if we have an element to scroll to first.

mozfly - could you verify this fixes this bug and would you make a comment in
bug 299168 as to whether you can still reproduce that error?

Comment 2

[Benjamin Smedberg]

Comment on attachment 189219 [details] [diff] [review]
patch

r+a=bsmedberg assuming this actually fixes the problem

Comment 3

[bugzilla]

(In reply to comment #1)
> Created an attachment (id=189219) [edit]
> patch
> 
> Check if we have an element to scroll to first.
> 
> mozfly - could you verify this fixes this bug and would you make a comment in
> bug 299168 as to whether you can still reproduce that error?

The patch fixes this bug.

Comment 4

[Asaf Romano (gone)]

Checking in richlistbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/richlistbox.xml,v  <--  richlistbox.xml
new revision: 1.7; previous revision: 1.6
done

Comment 5

[Robert Strong (they/them - no direct email)]

*** Bug 303057 has been marked as a duplicate of this bug. ***