300465 - Outlook URL links open in a new window, not a new tab, ignoring preferences.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jason Bassford]

This is a specific offshoot of bug 121961, which was marked fixed and then
reopened because of this.

Additionally, opening in new tabs rather than windows was broken completely
recently, but fixed by bug 299444.  However, even though the "singlewindow"
extension used to be a workaround to bug 121961 - it no longer works.  Whatever
broke it at the time that bug 299444 was introduced has not been fixed.

Steps to reproduce.

1. Set preferences to always open links from applications in tabs rather than
Windows.

2. In Outlook, click on a URL link.

What actually happens:

A new browser window is opened.

What should happen:

A new tab in the existing browser window should be opened, as per the preference.

Comment 1

[Jason Bassford]

Oops - stupid typo.  This is a specific offshoot of bug 121969.  (At least I got
the dependency right.)

Comment 2

[Sven Grull]

OK. I found the solution. 
There is a bug in the singlewindow extension. 
From the js console:

Error: illegal character
Source File: chrome://singlewindow/content/singlewindow.js
Line: 342
Source Code: � � � � var newTab = topWin.window.gBrowser.addTab(url);

All you have to do to fix it is to remove the illegal characters in line 342 and
also in line 343. Just overwrite everything before the text starts with blanks
and everything works again.

Comment 3

[Jason Bassford]

Okay, bizarre.  I unpacked the .jar and looked at the singlewindow.js file.  I
didn't see any illegal characters - just spaces.  I deleted the spaces, and then
put them back in again.  That seemed to do the trick.  (Not that I understand that.)

Now, the extension is constantly throwing errors in the JavaScript Console (even
though things seem to be working despite that):

"Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://singlewindow/content/singlewindow.js :: anonymous :: line 362"  data:
no] Source File: chrome://singlewindow/content/singlewindow.js
Line: 362"

and
 
"Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://navigator/content/navigator.js :: Shutdown :: line 825"  data: no]"

Comment 4

[Jason Bassford]

Woohoo!  This has been fixed by the fix for bug 300485.