pango changes require to work with gtk 2.7 (cairo)

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: blizzard, Assigned: blizzard)

Tracking

Trunk
x86
Linux
Bug Flags:
blocking-aviary1.5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
Gtk 2.7 uses cairo for rendering and the the current pango code assumes that
that the xft context is being used.  Some small changes are required.
(Assignee)

Comment 1

13 years ago
Created attachment 189058 [details] [diff] [review]
update pango code to handle a cairo context

Comment 2

13 years ago
This makes the  nightly builds unusable when running on Fedora Rawhide.

Updated

13 years ago
Flags: blocking-aviary1.1?

Updated

13 years ago
Flags: blocking-aviary1.5? → blocking-aviary1.5-
Comment on attachment 189058 [details] [diff] [review]
update pango code to handle a cairo context

r=caillon.  roc, what say ye?
Attachment #189058 - Flags: superreview?(roc)
Attachment #189058 - Flags: review+
Attachment #189058 - Flags: superreview?(roc) → superreview+
Comment on attachment 189058 [details] [diff] [review]
update pango code to handle a cairo context

Needed lest we don't work with GTK+ >= 2.7
Attachment #189058 - Flags: approval1.8b4?

Comment 5

13 years ago
Given the current schedule of 1.5 and 2.0 and Fedoras six month release cycle
doesn't the "-" amount to the fact that the then current official Mozilla
release of Firefox 1.5 will be incompatible with the final release of Fedora
Core 5 when it is released?

Updated

13 years ago
Attachment #189058 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 6

13 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 7

13 years ago
Created attachment 190569 [details]
Dialogs without text

Some dialogs are still broken after this was checked in: Mozilla/5.0 (X11; U;
Linux i686; en-US; rv:1.8b4) Gecko/20050726 Firefox/1.0+

I'm posting this from the current Rawhide build in which the dialogs work but
there are other issues (startup and font rendering): Mozilla/5.0 (X11; U; Linux
i686; en-US; rv:1.8b3) Gecko/20050723 Fedora/1.1-0.2.4.deerpark.alpha2
Firefox/1.0+
Rawhide is using the exact same patch that was checked in.  Make sure you
rebuilt and exit all firefox processes.

Comment 9

13 years ago
(In reply to comment #8)
> Rawhide is using the exact same patch that was checked in.  Make sure you
> rebuilt and exit all firefox processes.

I figured you'd use the same patch for the Rawhide release which is why I'm a
bit puzzled about this. I even rebooted the machine and started firefox with a
fresh profile but the problem still remains.
Things have gotten worse with todays Rawhide update to gtk2-2.7.4, cairo-0.6.0
and pango-1.9.1 because now as soon as I see the save dialog pop up Firefox just
crashes.
With build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050801
Firefox/1.0+ I get the following error when starting firefox (after updating to
todays Rawhide):

firefox-bin: cairo-xlib-surface.c:1883: _xlib_glyphset_cache_create_entry:
Assertion `NOT_REACHED' failed.
./run-mozilla.sh: line 131:  2948 Aborted                 "$prog" ${1+"$@"}
Let me clarify: I get the error mentioned in my last comment when I try to save
an image or a page, not on the actual startup of firefox. Sorry for the confusion.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.