300501 - Move GetBugActivity into Bug.pm

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

This routine is actually in CGI.pl.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

This routine is only used in process_bug.cgi (midair collisions) and
show_activity.cgi.

Comment 2

[Frédéric Buclin]

Comment on attachment 189067 [details] [diff] [review]
patch, v1

>+        my $activity_visible = 1;
>+
>+        # check if the user should see this field's activity
>+        if ($fieldname eq 'remaining_time'
>+            || $fieldname eq 'estimated_time'
>+            || $fieldname eq 'work_time'
>+            || $fieldname eq 'deadline')
>+        {
>+            $activity_visible = UserInGroup(Param('timetrackinggroup')) ? 1 : 0;
>+        } else {
>+            $activity_visible = 1;
>+        }

I could even set $activity_visible as undefined initially, or remove the ELSE
block. That's a nit anyway.

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 189067 [details] [diff] [review]
patch, v1

Tested on tip, looks to be working. I tried midairing and viewing bug activity
with various fields including private attachments.

Comment 4

[Frédéric Buclin]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.244; previous revision: 1.243
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.265; previous revision: 1.264
done
Checking in show_activity.cgi;
/cvsroot/mozilla/webtools/bugzilla/show_activity.cgi,v  <--  show_activity.cgi
new revision: 1.16; previous revision: 1.15
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.82; previous revision: 1.81
done