300534 - Internal Narcissus functions showing up in objects' prototypes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

There are a few functions that we use internally in the implementation that need
to be __defineProperty__'d to be non-enumerable.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Make the functions non-enumerable

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 189114 [details] [diff] [review]
Make the functions non-enumerable

>+Array.prototype.__defineProperty__('top', function () { 
>+        return this.length && this[this.length-1]; 
>+    }, false, false, true);

Looks great, only comment is to indent this the same way you indented the
earlier ones: one basic offset for the body statement, 0 for the closing brace
and trailing args to __defineProperty__.  Alternative:

Array.prototype.__defineProperty__('top',
    function () { 
	return this.length && this[this.length-1]; 
    },
    false, false, true);

or even:

Array.prototype.__defineProperty__(
    'top',
    function () { 
	return this.length && this[this.length-1]; 
    },
    false, false, true
);

/be

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.