300537 - Installer: random talkback percentage check is backwards

Status: RESOLVED INVALID

(Firefox :: Installer, defect)

Description

[Jesse Ruderman]

This comparison is backwards:
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/windows/wizard/setup/extra.c#4527

      if((siCNode->lRandomInstallPercentage != 0) &&
         (siCNode->lRandomInstallPercentage <= siCNode->lRandomInstallValue) &&
        !(siCNode->dwAttributes & SIC_DISABLED))

For example, if you set the Talkback percentage to 20% (lRandomInstallPercentage
== 20), 80% of users get Talkback.

This code appears in several places in the Mozilla source tree.

Comment 1

[Benjamin Smedberg]

If this is truly so, then *none* of the dpa2 testers are going to get
talkback... very bad.

Comment 2

[chris hofmann]

    chase and dveditz also worked out a short term solution to get alpha2 providing
    talkback data by reverting the config.in

    we should get the correct fix made on the trunk as soon as the tree opens for
    deerpark beta1 development.

Comment 3

[Daniel Veditz [:dveditz]]

wait, the test looks backward, but it's not adding the package it's deciding
whether to *exclude* the package. If the test is true it does:

        siCNode->dwAttributes &= ~SIC_SELECTED;

Which makes sense, the attributes (see [Component QFA]) already include
SELECTED, so this is a way to randomly turn it off.

I may still need more sleep... could someone double-check me before marking this
INVALID?

Comment 4

[Benjamin Smedberg]

dveditz/jay, what is the status here? Did we test the builds with the random
install percent set to 100?

Comment 5

[Asa Dotzler [:asa]]

This was determined to be invalid, I believe.