300551 - Eliminate deprecated Bugzilla::DB routines from User.pm and Token.pm

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

.

Comment 1

[Frédéric Buclin]

Attachment: patch for Token.pm, v1

I prefer to submit two patches... one for Token.pm, another one for User.pm.

Comment 2

[Frédéric Buclin]

Attachment: patch for User.pm, v1

And here is the one for User.pm. I did a big cleanup in User::match().

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 213827 [details] [diff] [review]
patch for Token.pm, v1

>+    my ($issuedate, $tokentype, $eventdata, $loginname, $realname) =
>+        $dbh->selectrow_array('SELECT ' . $dbh->sql_date_format('issuedate') . ',
>+                                      tokentype , eventdata , login_name , realname

Nit: Remove extra spaces before commas so that this line fits inside 80 chars.

Comment 4

[Teemu Mannermaa (:wicked)]

Comment on attachment 213839 [details] [diff] [review]
patch for User.pm, v1

>-                      "LENGTH(login_name) AS namelength " .
>-        $query     .= " ORDER BY namelength";

Removing these lines from the two queries changes the list that is returned for limited lists. I don't think login name length was a good sort but changing this to an unspecified DB order (?) doesn't sound right either. Maybe instead order the results with login_name and/or realname to get consistent lists?

Comment 5

[Frédéric Buclin]

Attachment: patch for User.pm, v2

Comment 6

[Teemu Mannermaa (:wicked)]

Comment on attachment 214251 [details] [diff] [review]
patch for User.pm, v2

Seems to still work. Even on Pg.

Comment 7

[Frédéric Buclin]

Checking in Bugzilla/Token.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v  <--  Token.pm
new revision: 1.40; previous revision: 1.39
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.103; previous revision: 1.102
done