300586 - Move event dispatching from revalidate to refresh

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

The errata moves the dispatching of xforms-readonly/xforms-readwrite, etc. from
xforms-revalidate to xforms-refresh. This means changing the SetStatesInternal()
call from nsXFormsModel::Revalidate() to nsXFormsModel::Refresh(), and possibly
getting rid of mControlsNeedingRefresh.

Comment 1

[Allan Beaufour]

Attachment: Testcase

Comment 2

[Allan Beaufour]

Attachment: Patch

Comment 3

[aaronr]

Comment on attachment 189758 [details] [diff] [review]
Patch

looks ok to me.  r=me

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 189758 [details] [diff] [review]
Patch

>diff -X patch-excludes -uprN -U8 xforms/nsXFormsModelElement.cpp xforms.newseq/nsXFormsModelElement.cpp
>--- xforms/nsXFormsModelElement.cpp	2005-07-19 14:16:28.000000000 +0200
>+++ xforms.newseq/nsXFormsModelElement.cpp	2005-07-19 14:17:18.000000000 +0200
>@@ -524,20 +524,16 @@ nsXFormsModelElement::GetInstanceDocumen
>     // Copy the form control list as it stands right now.
>@@ -665,16 +661,28 @@ nsXFormsModelElement::Revalidate()
>            NS_ConvertUCS2toUTF8(name).get(),
>            (void*) node);
>   }
> #endif
> 
>   // Revalidate nodes
>   mMDG.Revalidate(&mChangedNodes);
> 
>+return NS_OK;
>+}

The return should be indented by 2 spaces :)

>+
>+NS_IMETHODIMP
>+nsXFormsModelElement::Refresh()
>+{
>+#ifdef DEBUG
>+  printf("nsXFormsModelElement::Refresh()\n");
>+#endif
>+  nsPostRefresh postRefresh = nsPostRefresh();
>+
>+

nit: Why 2 spaces?

Comment 5

[Allan Beaufour]

Fixed Doron's two nits, and checked in.