Closed Bug 300590 Opened 19 years ago Closed 19 years ago

bidi.browser.ui disappeared from about:config in deerpark

Categories

(Core :: Preferences: Backend, defect, P3)

Product:
Core
Component:
Preferences: Backend
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta4

People

(Reporter: eyalben, Assigned: asaf)

References

Details

(Keywords: fixed1.8)

Attachments

(2 files)

patch
1.29 KB, patch
mconnor
: review+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review
seamonkey patch
1.66 KB, patch
neil
: review+
neil
: superreview+
asa
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0.4 (Ubuntu package 1.0.2 MFSA2005-44)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0.4 (Ubuntu package 1.0.2 MFSA2005-44)

In the new deerpark alpha 2 (havn't checked on alpha 1), there is no
"bidi.browser.ui" in the about:config, so there isn't any way to enable to extra
bi-di support (this allowes using ctrl+shift+x to switch direction, etc..).

Does anyone know where's this option gone?

Reproducible: Always

Steps to Reproduce:
1.go to about:config
2. write bidi in the search
3. the bidi.browser.ui doesn't there



Expected Results:  
bidi.browser.ui should have been there, with an option to enable i.
Assignee: nobody → bugs.mano
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: Extension/Theme Manager → Preferences: Backend
OS: Linux → All
Product: Firefox → Core
Hardware: PC → All
Target Milestone: --- → mozilla1.8beta4
Version: unspecified → Trunk
Status: NEW → ASSIGNED
Priority: -- → P3
Depends on: bidiui
Keywords: aviary-landing
Attached patch patch — — Splinter Review 

        Attachment #189216 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #189216 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 189216 [details] [diff] [review]
patch

I don't remember you adding the preference to about:config, plus you use
try/catch because the pref does not normally exist.

        Attachment #189216 -
        Flags: review?(mconnor) → review+

    
    

    
  
Comment on attachment 189216 [details] [diff] [review]
patch

I'll attach a new patch for seamonkey which removes the try, catch.

        Attachment #189216 -
        Flags: superreview?(neil.parkwaycc.co.uk) → approval1.8b4?

    
  

        Attachment #189216 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
firefox part is checked in.
Keywords: aviary-landing

    
    

    
  

      
      
      
      

        Attached patch
          
          
        seamonkey patch
        — 
          — Splinter Review
      

    


  

        Attachment #194435 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #194435 -
        Flags: review?(neil.parkwaycc.co.uk)

    
  

        Attachment #194435 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #194435 -
        Flags: superreview+

        Attachment #194435 -
        Flags: review?(neil.parkwaycc.co.uk)

        Attachment #194435 -
        Flags: review+

    
    

    
  
Comment on attachment 194435 [details] [diff] [review]
seamonkey patch

requesting 1.8branch approval (seamonkey-only patch)

        Attachment #194435 -
        Flags: approval1.8b4?

    
  

        Attachment #194435 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
fixed branch & trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

    
    

    
  
why not make it behave like this:
No explicit setting -> autodetect from oocale
Setting to false    -> disable UI
Setting to true     -> enable UI

    
    

    
  
hm, I suppose that that would sorta be the opposite of what this bug was
requesting :)
Summary: bidi.browser.ui disappeared in deerpark → bidi.browser.ui disappeared from about:config in deerpark

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: