Closed Bug 300607 Opened 19 years ago Closed 19 years ago

label with both src and inline content show both

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: allan, Assigned: smaug)

References

(
URL
)

Details

Attachments

(3 files, 1 obsolete file)

External label
14 bytes, text/plain
Details
Testcase
2.22 KB, application/xhtml+xml
Details
v2
1.15 KB, patch
doronr
: review+
aaronr
: review+
Details | Diff | Splinter Review 
<label src="yada.txt">sss</label> shows both the content of yada.txt and 'sss'.
Attached file External label — 

  

  



    
    

    
  

      
      
      
      

        Attached file
          
        Testcase
        — 
      

    


  

  

  



    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed patch (obsolete)
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #189174 -
        Flags: review?(doronr)

    
    

    
  
Comment on attachment 189174 [details] [diff] [review]
proposed patch

better patch coming,
with some additional cleanups

  

  



        Attachment #189174 -
        Flags: review?(doronr)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #189174 -
        Attachment is obsolete: true
Assignee: allan → smaug
Status: NEW → ASSIGNED

        Attachment #189180 -
        Flags: review?(doronr)

        Attachment #189180 -
        Flags: review?(doronr) → review+

        Attachment #189180 -
        Flags: review?(aaronr)

    
    

    
  
Comment on attachment 189180 [details] [diff] [review]
v2

A comment in label in the xbl file might not be a bad idea.  It took me a
couple of minutes to figure out exactly what was going on with content and
anoncontent and where label text was going.  But code change looks dandy!

r=me.

  

  



        Attachment #189180 -
        Flags: review?(aaronr) → review+

    
    

    
  
checked in

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: