300609 - wrong result of index() function when hit <trigger appearance="minimal"> inside <repeat>

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Splash]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b2) Gecko/20050706 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b2) Gecko/20050706 Firefox/1.0+

index() function not works properly when used in trigger with
appearance="minimal" inside repeat construction. It always return '1'.

Reproducible: Always

Steps to Reproduce:
1. Open attached sample in browser.
2. Hit on button 2 and close dialog box
3. Hit on label 2 and close dialog box

Actual Results:  
First dialog box show 2 and second dialog box show 1

Expected Results:  
Both dialog box should show 2

I use Mozilla XForms 0.2

Comment 1

[Splash]

Attachment: Test case for this bug

Comment 2

[Allan Beaufour]

Confirmed. I wonder why...

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> Confirmed. I wonder why...

I think the reason is that the minimal trigger does not get focussed when you
click on it -> the repeat row does not get focus either -> the index is not changed

I guess all triggers should either get focus or not, but giving focus to a
<span> (which the minimal trigger is)?

Comment 4

[Allan Beaufour]

Attachment: Patch

Sets tabindex="0" for minimal trigger so it is focusable, and you can tab your
way to it, which makes sense for triggers IMHO.

Comment 5

[Allan Beaufour]

Checked in.