300620 - Deletion of a product yields "Insecure dependency in parameter 3" when useclassification is on

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Ben Wern]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Deleting a product (without any bugs inside) yields:

Insecure dependency in parameter 3 of
DBI::db=HASH(0x8000000101327270)->selectrow_array method call while running with
-T switch at /opt/apps/nsm/cgi-bin/bugzilla/editproducts.cgi line 172, <DATA>
line 225.

This installation has classification on.

Reproducible: Always

Steps to Reproduce:
1. Select Product to delete (with zero bugs contained)
2.
3.

Actual Results:  
Error as above.

Expected Results:  
Removed the product.

This form does not have a version selector, but note that this bug report is for
2.20rc1.

Comment 1

[Frédéric Buclin]

This error message appears only when useclassification is turned on. Else it
works as expected.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 189178 [details] [diff] [review]
patch, v1

Looks like this is a regression from bug 289580 and affects both 2.20 branch
and tip. This patch seems to fix the problem. I tested this on 2.20 branch and
also verified that this can be applied cleanly on tip.

Comment 4

[Frédéric Buclin]

tip:

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.86; previous revision: 1.85
done


2.20rc1:

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.85.2.1; previous revision: 1.85
done