300684 - missing_version_or_component error message is not translatable

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

Bug 223570 introduced the missing_version_or_component error message in
user-error.html.tmpl. This error message uses a parameter missing_item, which is
displayed in the error message. The code throwing this error message is expected
to specify either "Component" or "Version".

This missing_item parameter may not be displayed because the template file
cannot be translated (for localized templates) if it is.

One way to solve this would be to accept "component" or "version" and set a
missing_item_displayed (or something) TT variable depending on missing_item, and
display that.
Quite similarly, I think <a href="edit[% missing_item FILTER none %]s.cgi should
be rewritten along the same lines.

Another way (I prefer this one) would be to have two separate error messages.

Comment 1

[A. Karl Kornel]

I have absolutely no problem with doing 2 error messages.  I'll take a look now.

Comment 2

[A. Karl Kornel]

Attachment: Patch v1

Splits the one error message into two.	In addition to easing localization,
this will also make it easier for people who wish to replace the terms
"template" or "component" with terms of their own choice.

Also changes the 2 places in globals.pl where the errors are actually thrown.

Requesting review from somebody on both the CGI list and the template list.

Comment 3

[Jouni Heikniemi]

Comment on attachment 189239 [details] [diff] [review]
Patch v1

Ecch... Why did we ever create that monster. ;-)

r=jouni

Comment 4

[A. Karl Kornel]

Requesting approval for checkin to tip and 2.20.

Comment 5

[Colin Ogilvie [:cso]]

Checked in:

2.20:
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.326.2.3; previous revision: 1.326.2.2
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.115.2.1; previous revision: 1.115
done

Trunk:
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.329; previous revision: 1.328
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.116; previous revision: 1.115
done