300686 - nsTextFormatter.cpp error, thunderbird 1.0.5

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[g. fischer]

User-Agent:       Mozilla/5.0 (X11; U; IRIX64 IP27; en-US; rv:1.8b3) Gecko/R-A-C Firefox/1.0+
Build Identifier: 

irix 6.5.27, mipspro 7.43, tb 1.0.5
----------------

cc-1020 CC: ERROR File = ../../../mozilla/xpcom/ds/nsTextFormatter.cpp, Line = 910
  The identifier "va_copy" is undefined.

        VARARGS_ASSIGN(nas[cn].ap, ap);
        ^


Reproducible: Always

Comment 1

[g. fischer]

*** Bug 300677 has been marked as a duplicate of this bug. ***

Comment 2

[g. fischer]

same happened using a current cvs checkout.
looked at the cvs log and found this:

revision 1.15
date: 2003/02/23 06:59:18;  author: seawood%netscape.com;  state: Exp;  lines: +3 -1
branches:  1.15.36;
Use va_copy if available for VARARGS_ASSIGN
Bug #187180 r=blizzard sr=brendan

could it be this?

Comment 3

[g. fischer]

Attachment: remove va_copy define

created a patch!
not elegant but works.
since i'm no coder you might want to add an os dep. for this or whatever.

Comment 4

[g. fischer]

seems to be fixed in cvs but is there in 1.0.6

Comment 5

[Frank Wein [:mcsmurf]]

Um no? http://lxr.mozilla.org/mozilla/source/xpcom/ds/nsTextFormatter.cpp#68
still shows the same code. Anyway i don't think the fix is that easy to just
remove the HAVE_VA_COPY ifdef there (might be needed on other platforms)?

Comment 6

[g. fischer]

(In reply to comment #5)
> Um no? http://lxr.mozilla.org/mozilla/source/xpcom/ds/nsTextFormatter.cpp#68
> still shows the same code.

however, cvs checkouts work. mozilla 1.7.11 e.g. did not.

> Anyway i don't think the fix is that easy to just
> remove the HAVE_VA_COPY ifdef there (might be needed on other platforms)?

as i said i ain't a coder but the 'that easy' solutions worked for me.

Comment 7

[Frank Wein [:mcsmurf]]

Do you have the config.log of a FF/TB 1.0.x or Mozilla 1.7.x build available? If
yes, could you attach it to this bug here (ZIP it if necessary)?

Comment 8

[g. fischer]

not present in trunk anymore.

Comment 9

[g. fischer]

(In reply to comment #8)
> not present in trunk anymore.
> 


sorry, it's not gone.
must have been ignored by my checkouts. completely new checkout still has it.
will attach the log...

Comment 10

[g. fischer]

Attachment: buildlog

the buildlog

Comment 11

[g. fischer]

fyi:
tried gcc 4.1 and it seems like the patch doesn't have to be applied for it.
in fact if it is applied gcc stops with an error.

Comment 12

[g. fischer]

got it:

there are 2 versions of the c compiler: cc and c99. c99 has some additional features. also va_copy. so if c99 is the default va_copy is detected but it seems like the required header is not included anyway.
it is /usr/include/internal/stdarg_core.h.