300738 - faulty search plugin import on upgrade

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[kagenoyoake]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5 (ax)

When upgrading from an old version of firefox to a new one I've noticed that the
search plugin list is filled with the plugins that I deleted the last time I
upgraded, while they are useful, Firefox should probabally check to see if there
are already searchplugins in the target folder and not add new ones if there are
(or at least have an option under the custom fork in the installer).

Reproducible: Always

Steps to Reproduce:
1. Install (an outdated version of) Firefox.
2. Delete some search plugins manually.
3. Upgrade Firefox, they WILL come back (at least on my computer(s) it has
happened every time)

Actual Results:  
The search plugins I deleted came back.

Expected Results:  
Realised the search plugins had been customized and left them as they were
(instead of adding new ones).

This problem is very minor, incredibly easy to work around, and occured in every
upgrade of firefox since 1.0 I believe (or whenever search plugins were bundled
I wanted to delete (i always delete ebay, amazon, creative commons, and yahoo).

Comment 1

[Ria Klaassen (not reading all bugmail)]

I see the same happening in 1.0+.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050714
Firefox/1.0+ ID:2005071401

Comment 2

[Adam Guthrie]

After the fix for bug 123315, search engines installed by the user are installed
in the /searchplugins/ directory of their profile. The default search plugins
are still installed in Firefox's main folder. Probably WONTFIX, because whare
you're requesting is that we don't ship the default search plugins.

Comment 3

[Benjamin Smedberg]

This is WONTFIX for 1.1, and I have a better plan for 1.5 involving making
searchplugins "extensions" of a sort which can be persistently disabled.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 284625 has been marked as a duplicate of this bug. ***

Comment 5

[:Gavin Sharp [email: [e-mail]]]

*** Bug 284624 has been marked as a duplicate of this bug. ***

Comment 6

[Erlendur S Thorsteinsson]

(In reply to comment #2)
>
> Probably WONTFIX, because whare you're requesting is that we don't
> ship the default search plugins.

No, that's not the request.  On a fresh install these search plugins can be installed.  But on an upgrade install then settings should not be modified, including not re-adding search plugins that were previously installed but subsequently deleted by the user.

Comment 7

[Dave Townsend [:mossop]]

*** Bug 318976 has been marked as a duplicate of this bug. ***

Comment 8

[Alf Eaton]

(In reply to comment #3)
> This is WONTFIX for 1.1, and I have a better plan for 1.5 involving making
> searchplugins "extensions" of a sort which can be persistently disabled.

Seeing as 1.5 has already been released and this bug still exists, could this be re-opened again?

Also, the hardware and OS assigned to this bug should be changed to 'all'.