300773 - Thunderbird 1.0.5 name misspelled in release (lower-case 't' instead of upper-case 'T')

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Len Laughridge]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

The just-released Thunderbird 1.0.5 is present as 'thunderbird.app' on the
downloaded diskimage.  This causes errors on installation when dragged into
/Applications (remember - case-insensitive but case-respecting filesystem!),
does not successfully overwrite the previous installation, and aliases/Dock
icons are not pointed correctly.  

Reproducible: Always

Steps to Reproduce:
1.  Download diskimage of 1.0.5 from mozilla.org
2.  Look at the filename of the app on the diskimage
3.  Oops.  
Actual Results:  
thunderbird.app != Thunderbird.app

Comment 1

[Chase Phillips]

Minusing for 1.0.6.  Nominating for 1.0.7.

Comment 2

[Len Laughridge]

Really - why put off correcting this mistake for another whole revision?   

All you need to do is s/thunderbird\.app/Thunderbird\.app/g  in the build script.

Bad user experience due to a sloppy mistake == bad PR.  

Comment 3

[Rajiv Manglani]

the name of the disk image (the volume on the disk image) is also lowercase and should be
properly capitalized. 

Comment 4

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 301610 has been marked as a duplicate of this bug. ***

Comment 5

[Chase Phillips]

I imagine this is related to triton's replacement of hilo's branch release build.

Comment 6

[Chase Phillips]

The trunk defines _APPNAME using MOZ_APP_DISPLAYNAME where the branch uses
MOZ_APP_PKGNAME.

Aviary-1.0.1:
http://lxr.mozilla.org/aviary101branch/source/xpinstall/packager/Makefile.in#120

Trunk:
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#95

Thunderbird 1.0.4 had 'Thunderbird.app' instead of 'thunderbird.app'?

Comment 7

[Chris Cooper [:coop] (he/him)]

Attachment: Use $MOZ_APP_DISPLAYNAME in xpinstall/packager/Makefile.in

Tried this out successfully on triton:

http://tinderbox.mozilla.org/showlog.cgi?log=Aviary-1.0.1/1122059940.10583.gz&fulltext=1

Comment 8

[Stefan [:stefanh]]

*** Bug 301569 has been marked as a duplicate of this bug. ***

Comment 9

[Zach Lipton [:zach]]

This is a regression, as Thunderbird 102 had the upper-case "T" on Mac.
Interestingly enough,
http://lxr.mozilla.org/aviary101branch/source/mail/app/Makefile.in#275 shows
that we use an upper-case "T and Bonsai isn't reporting anything particularly
useful. It's all rather bizarre. 

Comment 10

[Chase Phillips]

Comment on attachment 190190 [details] [diff] [review]
Use $MOZ_APP_DISPLAYNAME in xpinstall/packager/Makefile.in

This patch is good but we should narrow down the regression window.  If the
regression wasn't caused by a code change on the branch, I'd like for us to be
able to fix this without needing to land a patch.

Comment 11

[Scott MacGregor]

Chase, my optimized branch build generated a build with the correct name. i.e
with a captial T. That was a brand new tree. So it seems strange that this
particular branch build machine would be making a build with a lower case name.

Comment 12

[Chase Phillips]

(In reply to comment #11)
> Chase, my optimized branch build generated a build with the correct name. i.e
> with a captial T. That was a brand new tree. So it seems strange that this
> particular branch build machine would be making a build with a lower case name.

Thanks Scott.

Likely places to check:
  * differences in Mac OS X version
  * differences in XCode version
  * differences in Tinderbox client scripts

I believe cadence used to do Thunderbird Mac trunk builds and hilo used to do
Thunderbird Mac aviary1.0.1 branch builds.  triton took over for both systems
sometime between Thunderbird 1.0.2 and 1.0.5.

Comment 13

[Chris Cooper [:coop] (he/him)]

Does March 28th sound like a likely date for the build switch to triton? I've
found the following:

http://archive.mozilla.org/pub/thunderbird/nightly/2005-03-28-04-aviary1.0.1/thunderbird-mac-MachO.dmg
- Application name is Thunderbird

http://archive.mozilla.org/pub/thunderbird/nightly/2005-03-28-18-aviary1.0.1/thunderbird-powerpc-apple-darwin7.8.0.dmg
- Application name is thunderbird

The disk image nomenclature (Mach vs. Darwin) indicates to me that this is when
the switch likely occurred.

Comment 14

[Chase Phillips]

Bonsai log for that time
(http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=AviaryBranchTinderbox&branch=AVIARY_1_0_1_20050124_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-27&maxdate=2005-03-29&cvsroot=%2Fcvsroot)
shows a change I made to fix Thunderbird Mac packaging using Mozilla's build config.

Comment 15

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 302605 has been marked as a duplicate of this bug. ***

Comment 16

[Adam Guthrie]

*** Bug 301887 has been marked as a duplicate of this bug. ***

Comment 17

[Chris Cooper [:coop] (he/him)]

Does this need further investigation or can it safely be closed?

Comment 18

[Daniel Veditz [:dveditz]]

Now that we're in this state which is worse? If we change back to 'T' then people who successfully navigated these problems in 1.0.5 through 1.0.7 will have them all over again. If we leave it 't' that just pushes the problem off until they upgrade to 1.5

Comment 19

[Chris Cooper [:coop] (he/him)]

1.0.x has been EOLed.