300786 - Flash Player loaded via ActiveX Plug-in handles click only once.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Masatoshi Kimura [:emk]]

Reproducible: Always

Steps to Reproduce:
1. Install Mozilla ActiveX Plug-in.
2. Add the following line into your activex.js to allow Flash Player:
pref("capability.policy.default.ClassID.CIDD27CDB6E-AE6D-11CF-96B8-444553540000",
"AllAccess");
3. Navigate to http://www.oersted.co.jp/~emk/2005/07/15/
4. If tabs are not displayed, return to step 1 and recheck your configuration.
5. Click one tab (e.g. "Firefox") to select.
6. Click another tab (e.g. "Thunderbird") before click other place.

Actual Results:
"Thunderbird" tab is not selected.

Expected Results:
"Thunderbird" tab should be selected.
If you click non-flash area between step 5 and step 6,  you can change tab
selection one more time.
If you are using Netscape Plug-in version of Flash Player, everything works as
expected. Netscape Plug-in version is here:
http://www.oersted.co.jp/~emk/2005/07/15/index_ns.html

Comment 1

[Masatoshi Kimura [:emk]]

Here's the cause:
1. Click Flash ActiveX control.
2. Flash ActiveX control got focus.
3. Click one more time.
4. Native window associated with nsObjectFrame will receive WM_MOUSEACTIVATE.
5. WM_MOUSEACTIVATE handler dispatches the NS_PLUGIN_ACTIVATE event.
6. nsObjectFrame handles the NS_PLUGIN_ACTIVATE event to call content->SetFocus().
7. nsEventStateManager::SendFocusBlur() calls widget->SetFocus().
8. nsWindow::SetFocus() in turn calls native ::SetFocus(), but focused window is
different from ActiveX control's one.
9. ActiveX control's window will receive WS_KILLFOCUS.
10. Flash control seems to give up tracking mouse click.

If you are using Netscape Plug-in version, NS_PLUGIN_ACTIVATE is not dispatched
because Flash Plug-in handles WM_MOUSEACTIVATE on its own.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Patch rv1.0

Handling WM_MOUSEACTIVATE to suppress NS_PLUGIN_ACTIVATE on nsObjectFrame

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 189322 [details] [diff] [review]
Patch rv1.0

I'm sorry, but I can't review this patch.  I'm not the module owner for this
code, and I have no idea what either the core or the patch is doing...

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 189322 [details] [diff] [review]
Patch rv1.0

This patch no longer works due to fix for bug 306209.
We need another approach to solve the prolem.

Comment 5

[Masatoshi Kimura [:emk]]

My patch for bug-org 323142 also fixed this.