300807 - browser.offline stores state ioservice should: can lead to problems

Status: UNCONFIRMED

(Toolkit :: Startup and Profile System, defect)

Description

[Fritz Schneider]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

On/offline state is apparently stored in the browser.offline preference. This
preference is read at startup and used to set the offline attribute on the
ioservice. The preference doesn't actually do anything -- it just stores UI
state. The real state is in the ioservice. The state doesn't belong in a
preference and the fact that it is can lead to problems. See the example in the
reproducability steps.


Reproducible: Always

Steps to Reproduce:
1. Set browser.offline to true
2. Notice you can still navigate
3. Open a new window
4. When the new window starts up it notices browser.offline is true, and
disables the ioservice
5. You try to navigate somewhere not in your cache and fail

Actual Results:  
can't navigate

Expected Results:  
should have been disabled when browser.offline is set to false, not when a new
window is opened. or better yet, do away with  the preference

Comment 1

[Wayne Mery (:wsmwk)]

would this problem be gone with newer FF and the better online/offline architecture?

Comment 2

[Martin Sch]

In user.js, I was setting browser.offline to true.
The reason is that I have many open tabs, but when I start mozilla, it should not load all tabs every time. So I prefer to start offline and switch it online then.

But this does not work any longer with FF 4.