300827 - Toolbar icons showing up in menu items on Mac OS X

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Scott MacGregor]

Using todays 7/14 build. 

1) Open a compose window
2) Click on one of the toolbar buttons that have a drop down menu (attachments
or security)
3) Some of the menuitems for these buttons are checkboxes.
4) For these checkbox menu items, if the item is unchecked, we are showing the
toolbar button image next to the menu item check instead of a blank space. For
items that are checked, the checkmark is drawn correctly.

I am not sure when this first started. Maybe Mano has some ideas.

Comment 1

[Scott MacGregor]

this problem is really weird. I'm still seeing it in today's 7/18 builds. 

Comment 2

[Asaf Romano (gone)]

FYI, list-style-image is inherited.

Comment 3

[Scott MacGregor]

I wonder why I don't see this in Firefox. Maybe they don't have any toolbar
buttons with menu lists attached to them, which in turn are checked menu items.

Comment 4

[Scott MacGregor]

Is list-style-image only inherited on Mac OS X?

Comment 5

[Scott MacGregor]

Attachment: the fix

qute/gnomestripe/winstripe all have CSS to make sure menus don't inherit the
list-style-image attribute. I made pinstripe do the same to fix this issue.

See:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/global/menu.css#52

Comment 6

[Asaf Romano (gone)]

Comment on attachment 190498 [details] [diff] [review]
the fix

r=mano

Comment 7

[Scott MacGregor]

Comment on attachment 190498 [details] [diff] [review]
the fix

Asking Darin for a quick toolkit moa.

Comment 8

[Scott MacGregor]

Comment on attachment 190498 [details] [diff] [review]
the fix

looking for a quick toolkit moa.