Toolbar icons showing up in menu items on Mac OS X

RESOLVED FIXED in Thunderbird1.1

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Scott MacGregor, Assigned: Scott MacGregor)

Tracking

Trunk
Thunderbird1.1
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

696 bytes, patch
mano
: review+
Benjamin Smedberg
: superreview+
Benjamin Smedberg
: approval1.8b4+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
Using todays 7/14 build. 

1) Open a compose window
2) Click on one of the toolbar buttons that have a drop down menu (attachments
or security)
3) Some of the menuitems for these buttons are checkboxes.
4) For these checkbox menu items, if the item is unchecked, we are showing the
toolbar button image next to the menu item check instead of a blank space. For
items that are checked, the checkmark is drawn correctly.

I am not sure when this first started. Maybe Mano has some ideas.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
(Assignee)

Comment 1

13 years ago
this problem is really weird. I'm still seeing it in today's 7/18 builds. 
FYI, list-style-image is inherited.
(Assignee)

Comment 3

13 years ago
I wonder why I don't see this in Firefox. Maybe they don't have any toolbar
buttons with menu lists attached to them, which in turn are checked menu items.
(Assignee)

Comment 4

13 years ago
Is list-style-image only inherited on Mac OS X?
(Assignee)

Comment 5

13 years ago
Created attachment 190498 [details] [diff] [review]
the fix

qute/gnomestripe/winstripe all have CSS to make sure menus don't inherit the
list-style-image attribute. I made pinstripe do the same to fix this issue.

See:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/qute/global/menu.css#52
Attachment #190498 - Flags: review?(bugs.mano)
Comment on attachment 190498 [details] [diff] [review]
the fix

r=mano
Attachment #190498 - Flags: review?(bugs.mano) → review+
(Assignee)

Comment 7

13 years ago
Comment on attachment 190498 [details] [diff] [review]
the fix

Asking Darin for a quick toolkit moa.
Attachment #190498 - Flags: superreview?(darin)
(Assignee)

Comment 8

13 years ago
Comment on attachment 190498 [details] [diff] [review]
the fix

looking for a quick toolkit moa.
Attachment #190498 - Flags: superreview?(darin) → superreview?(benjamin)

Updated

13 years ago
Attachment #190498 - Flags: superreview?(benjamin)
Attachment #190498 - Flags: superreview+
Attachment #190498 - Flags: approval1.8b4+
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.