Closed Bug 300916 Opened 19 years ago Closed 19 years ago

Replace network.image.imageBehavior with permissions.default.image

Categories

(Firefox :: Migration, defect)

Product:
Firefox
Component:
Migration
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 alpha2

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Patch
10.39 KB, patch
mconnor
: review+
vlad
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
network.image.imageBehavior has been replace with permissions.default.image,
also there is migration code in the tree, we should use the new pref directly.
Assignee: nobody → bugzilla
Summary: Replace network.image.imageBehavior with permissions.default.image in nscp 4.x migrator → Replace network.image.imageBehavior with permissions.default.image
Attached patch Patch — — Splinter Review 

  

  



        Attachment #189431 -
        Flags: review?(bugs)

    
  

        Attachment #189431 -
        Flags: review?(bugs) → review?(mconnor)

    
  

        Attachment #189431 -
        Flags: approval-l10n+

    
    

    
  
Comment on attachment 189431 [details] [diff] [review]
Patch

just testing...

  

  



    
  

        Attachment #189431 -
        Flags: approval-l10n+

    
    

    
  
Comment on attachment 189431 [details] [diff] [review]
Patch

>-  { 0,
>+  { "Software\\Microsoft\\Internet Explorer\\Main",
>     "Display Inline Images",

r=me without this change, see the comment about 20 lines or so above, where it
says that 0 means "use previous key"

  

  



        Attachment #189431 -
        Flags: review?(mconnor) → review+

    
    

    
  
fix has been checked in

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
This patch can land on the 1.8 branch, right?

  

  



    
  

        Attachment #189431 -
        Flags: approval-branch-1.8.1?(mconnor)

    
  

        Attachment #189431 -
        Flags: approval-branch-1.8.1?(mconnor)

    
  

        Attachment #189431 -
        Flags: approval-branch-1.8.1?(vladimir)

        Attachment #189431 -
        Flags: approval-branch-1.8.1?(vladimir) → approval-branch-1.8.1+

    
    

    
  
mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp 	1.41.2.5
mozilla/browser/components/migration/src/nsIEProfileMigrator.cpp 	1.29.4.8
mozilla/browser/components/migration/src/nsDogbertProfileMigrator.cpp 	1.18.2.2
mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp 	1.20.2.4

  

  


Keywords: fixed1.8.1
Target Milestone: --- → Firefox 2 alpha2
Version: Trunk → 2.0 Branch

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: