300922 - Add cancel option in update download screen

Status: VERIFIED DUPLICATE of bug 336267

(Toolkit :: Application Update, enhancement)

Description

[Ajay S.]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

Can a cancel button be added to the update download screen so that the user be
allowed to cancel a update download in progress if required (a user may have
some reason to do so, the one below being an example but not the reason, so
please dont do a "This is a Alpha dude" reply)


I had filed a update bug report here

https://bugzilla.mozilla.org/show_bug.cgi?id=300903

that was closed as invalid shortly there after.

But before that, I was asked to update the url in about:config if I wanted to
desperately check updates for my just downloaded Deer Park Alpha 2. 

https://aus-staging.mozilla.org:8711/update2/0/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/update.xml


Me, being the idiot that I am, actually did so to find "Deer Park 1.0+" being
recommended "highly", for security reasons (I Think). Me being the stupid that I
am, actually clicked on the update / download button only to find that I could
not cancel it. The update screen now says that the 7.4MB update is now complete
and will need a restart to be applied. (after doing my course in Industrial
Design, I have got this habit of clicking on every link possible to check out
what happens, just like a monkey on steroids jumping about for the heck of it)

PS: I promise I will not look for any more bugs  / enhancements in Alpha version
s after this. Promise

Reproducible: Always

Steps to Reproduce:
1. Click on Help -> Update and check for updates
2. Assuming you have updates available (which is not true right now), click on
the download / update option (forgot which one exactly)
3. For whatever reason that may lead you to so, try to stop the update downlosd
in progress. You just can't, simple.

Actual Results:  
Deer Park Alpha 2 completed downloading 7.4 MB "Deer Park 1.0+" update. There
was no "intutive"  way to stop it.

Expected Results:  
Provide a "Cancel" option to stop the update download in progress.

Comment 1

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 300920 has been marked as a duplicate of this bug. ***

Comment 2

[Jaime Mitchell (use [e-mail] for email)]

Cancel mid stream was removed see bug 260700 however there may be a valid
request to have a cancel option during the download stage.

Comment 3

[Asa Dotzler [:asa]]

Mike, Darin, Ben, are we going to allow users to cancel an update before it's
forced on them at next restart? If not, can one of you won't fix this bug?

Comment 4

[Darin Fisher]

Our current thinking has been that by default users would not have a choice when
it comes to security updates.  However, for major application updates or updates
that may affect extensions, the user will be prompted to apply the update.  I
won't go so far as to mark this bug WONTFIX yet, as we may end up tweaking this
policy before final.

Comment 5

[matthew]

I agree with the problem, but the worst thing is it closes all your firefox windows and pressing the cancel button won't prevent that. I myself havelost quite a bit of forum posts to this problem. please add a working cancel button if it asks wether or not you want to close the download.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Since we didn't tweak the policy before final, and since there's been a general lack of complaint, and since I think that darin's original policy is quite the right idea, I'll mark this WONTFIX for now :)

Comment 8

[David E. Ross]

Two other bugs have been closed as duplicates of this one.  According to comment #6, " . . . there's been a general lack of complaint".  How many user complaints are required to refute that?  

Initiating a download of almost a megabyte (the MAR file to update 1.5.0.9 to 1.5.0.10) without allowing the user cancel is contrary to good design practices.  Users might want to do the update later, at a more optimum time.  This is especially true for users with dial-up connections (still about half the Internet users in the U.S.).  

Comment 10

[David E. Ross]

The duplicate bugs that have been closed in favor of this one clearly indicate that the asserted "general lack of complaint" is untrue.  Because of a lack of response to my comment #8, I am reopening this bug.  

Comment 12

[Michael Mak]

This would be an awesome feature to have for all OS

Comment 13

[WildcatRay]

I am currently sitting here watching the update dialog searching internet never, never land with no straightforward way of stopping it so I can instead download the day's nightly manually and go from there. My only other alternative is to search the forum thread to find which file(s) need to be updated and "abort" the update process that way.

There needs to be an easy, clearly intuitive way to stop/abort a clearly hanging update process and it should be applied to both Firefox 2 and 3.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008010104 Minefield/3.0b3pre ID:2008010104

Comment 14

[David E. Ross]

Re comment #7:  Can anyone explain how a Thunderbird bug was closed as a duplicate of a Firefox bug?  While the problem is the same, the product is quite different.  

Comment 15

[Phil Ringnalda (:philor)]

Software Update's a Toolkit component, it's just a historical accident that it's in Firefox, and will be until someone writes the Bugzilla code to allow smoothly moving a component to a new product.

Comment 17

[algotechie]

I need to cancel the download process because the button said "Check for update", not "Download the update". I do not intend to update quite yet, just wanted to know what's the new features in a new version if it's been released. Nor am I prepared to update without making sure that all my add-ons would continue to work.

There must be a cancel button.

Comment 18

[Robert Strong (they/them - no direct email)]

(In reply to algotechie from comment #17)
What you are referring to is the Firefox specific app update user interface in the about window which is Bug 600500 and this bug is about the download page in the Toolkit app update user interface.

Comment 19

[algotechie]

Thanks Robert Strong. I'll now go there.

Comment 20

[Robert Strong (they/them - no direct email)]

(In reply to algotechie from comment #17)

I need to cancel the download process because the button said "Check for
update", not "Download the update". I do not intend to update quite yet,
just wanted to know what's the new features in a new version if it's been
released. Nor am I prepared to update without making sure that all my
add-ons would continue to work.

There must be a cancel button.

The current behavior in the about dialog and in about:preferences is that if you have "Check for updates but let you choose to install them" you will get the option to download the update.

Note: the old UI is going away in Bug 1515484

In bug 336267 I am making it so an update that is already in progress can be cancelled when the client changes the option of "Automatically install updates (recommended)" to "Check for updates but let you choose to install them". With the way the update flow has changed that is the closest thing to this bug so duping to that bug