300927 - Selecting to install an update "Later" puts Software Update in "Resume downloading ..." state

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

To reproduce:
0. Install a day or two old trunk build
1. Help > Check for Updates ...
2. Download the update
3. When asked if you want to restart, pick "Later"
4. Go to the Help menu

Actual:
The Help menu option for Software Update says "Resume Downloading Deer Park
1.0+...". Selecting this brings you back to the "Downloading Update" screen
which says it's "Paused downloading Deer Park 1.0+" and only allows a user to
"Close" (which actually hides the dialog, see bug 300925).

Expected:
The Help menu option should say "Apply downloaded updates", and bring back the
dialog that asks the user if they want to restart now or later.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Also fix some other issues with this menu item in various other broken states

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Checking for the presence of update.status is much better, so I've changed my
patch to do that instead of checking for update.mar. 

Comment 4

[Darin Fisher]

Comment on attachment 190082 [details] [diff] [review]
Also fix some other issues with this menu item in various other broken states

r=darin, but was there also some IDL change to go along with this?

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

No - |state| is already (presently undocumented) on nsIUpdateService.idl ... I
was treating its implementation as a read/write property as just a regular js
property so it had no presence on the Patch object... since I wanted to add
special handling I needed to add a custom getter/setter for it and store its
value in _properties.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Checked in.