300958 - Focus moves incorrectly when clicking tabs

Status: RESOLVED DUPLICATE of bug 297421

(Toolkit :: UI Widgets, defect)

Description

[James Ross]

In Deer Park 1, where everything seems to work, clicking a tab would focus the
first item within the new visible page and, if no such thing exists, leave the
focus on the item outside of the tab 'system'. This means that in ChatZilla, for
example, the focus stayed in the input box when clicking tabs. This is good.

Move forward to Deer Park 2, and it's broken. Clicking a tab switches to it, but
ALWAYS focuses the tab! You can see this in the Firefox options, as well as in
ChatZilla.

From discussion with mconnor on IRC, this is because the focus is moving to the
tab element prior to selectNewTab being called, which checks if the tab is
focused, and finds it is - so selects the new tab always.

Comment 1

[Felix Miata]

Is this distinguishable from bug 300622 ?

Comment 2

[James Ross]

Yes, though they may be related.

Bug 300622 is about focus ending up on the nickname button in CZ when clicking a
tab - and applies to Mozilla/SeaMonkey only.

This bug is about focus ending up on the tab itself when clicking it - and
applies to Toolkit only.

It may be that changes from one have been semi-applied to the other, causing the
extra problems, but they should be kept mostly separate at least because they
are XPFE vs. Toolkit.

Comment 3

[Aaron Leventhal]

*** This bug has been marked as a duplicate of 297421 ***

Comment 4

[James Ross]

Technically, the other bug is a dup of this one. But no-one ever gives a ****
what I think or what is even right. And, well, bugger that.