300970 - access checks for install locations are performed repeatedly per location during a session

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

canAccess tests write access for each install location by creating a test
directory and then deleting it. Since an install location usually contains
multiple items this causes the same location to be tested for write access
repeatedly. I have a patch in progress and should have it finished by the end of
the weekend.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin - the write access checks are performed multiple times for each
install location during the init of the datasource as well as when clicking on
items in the ui. This can cause a noticeable slowdown especially for a location
on a network and this patch addresses this.

I should probably wait on Ben to land the patch he is working on which will
probably mean that I'll need to re-submit. If you'd prefer to wait until then
to review just cancel this review.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 189589 [details] [diff] [review]
patch

I have a slightly cleaner fix I'll submit after Ben lands his patch

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: simple patch

I doubt this patch will cause a problem for Ben's merge so asking for review.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: actual patch

This is the actual patch - doh!

Comment 5

[Benjamin Smedberg]

Comment on attachment 189636 [details] [diff] [review]
actual patch

Go ahead and land it now, as I haven't landed bug 297312 yet.

Comment 6

[Asaf Romano (gone)]

Checking in nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.127; previous revision: 1.126
done