300984 - stop creating undefined objects

Status: RESOLVED WONTFIX

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

We should definitely stop creating and returning undefined objects when the
parameters passed to the constructor "new Bugzilla::Module(@args)" are invalid.
We should fail using ThrowCodeError() instead.

A few minutes ago, I tried to edit the properties of a non-existent user. The
script created an undefined user object and failed when its ID was requested
later in the code. This does not make sense.

I prefer to die using ThrowCodeError() in the constructor itself than to let the
code catch it later (assuming the script is able to catch it instead of having
some strange behavior). And most of the time, it catches the undefined object by
a nice "Software error:"

This would also be a nice cleanup for this $self->{'error'} stuff in Bug.pm.

Comment 1

[Frédéric Buclin]

OK, I changed my mind. Sometimes, you want to do the check in the caller itself and take the appropriate action.