Closed Bug 301000 Opened 19 years ago Closed 19 years ago

Talkback doesn't work in seamonkey (due to rebranding)

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bzbarsky, Unassigned)

References

Details

(Keywords: regression, Whiteboard: happens on Linux and Mac, but not Windows see comment #9 and #10) 

Talkback in seamonkey stopped working as of the 2005-07-03-07 build. It works in
2005-07-02-07 build.  If I were a betting man, I would say the problem is the
rebranding....

This is a bit of a problem, because I've crashed 3 times in the last 2 days, and
I'd love to see those stacks.  :(
Flags: blocking-seamonkey1.0a+
could this log excerpt from creature point to the possible problem?

------------------------------------
processing talkback/symbols.make -C
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla deliver
make: Entering directory
`/cygdrive/c/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla'
echo finding pdb files
finding pdb files
mkdir -p ./dist/2005071604
cp `/bin/find . -path "./dist" -prune -o -name "*.dll" | sed "s/\.dll$/\.pdb/" |
xargs` ./dist/2005071604
cp: omitting directory `./dist'
cp: cannot stat `./fullsoft/brand/firefox/BrandRes.pdb': No such file or directory
cp: cannot stat `./fullsoft/brand/netscape/BrandRes.pdb': No such file or directory
cp: cannot stat `./fullsoft/brand/thunderbird/BrandRes.pdb': No such file or
directory
cp: cannot stat `./fullsoft/runtime/win/fullsoft.pdb': No such file or directory
cp: cannot stat `./stage/gre/gre/Embed/components/accessibility.pdb': No such
file or directory
cp: cannot stat `./stage/gre/gre/Embed/components/appshell.pdb': No such file or
directory
cp: cannot stat `./stage/gre/gre/Embed/components/caps.pdb': No such file or
directory
cp: cannot stat `./stage/gre/gre/Embed/components/chrome.pdb': No such file or
directory
[...]
cp: cannot stat `./stage/mozilla/xpcom/msvcirt.pdb': No such file or directory
cp: cannot stat `./stage/mozilla/xpcom/msvcrt.pdb': No such file or directory
make: [splitsymbols] Error 1 (ignored)
cp `/bin/find . -path "./dist" -prune -o -name "*.exe" | sed "s/\.exe$/\.pdb/" |
xargs` ./dist/2005071604
cp: cannot stat `./config/bin2rc.pdb': No such file or directory
cp: cannot stat `./config/makedep.pdb': No such file or directory
cp: cannot stat `./config/mangle.pdb': No such file or directory
[...]
cp: cannot stat `./stage/mozilla/gre/gre-win32-installer.pdb': No such file or
directory
cp: cannot stat `./stage/mozilla/mail/bin/PalmSyncInstall.pdb': No such file or
directory
cp: cannot stat
`./stage/mozilla/seamonkey-1.0a.en-US.win32.stub-installer/seamonkey-1.0a.en-US.win32.stub-installer.pdb':
No such file or directory
cp: cannot stat `./xpcom/sample/nsTestSample.pdb': No such file or directory
make: [splitsymbols] Error 1 (ignored)
cp `/bin/find . -path "./dist" -prune -o -name "*.EXE" | sed "s/\.EXE$/\.pdb/" |
xargs` ./dist/2005071604
cp: omitting directory `./dist'
make: [splitsymbols] Error 1 (ignored)

oh, wait... it's getting worse...
Just look at the list of package errors in the brief log:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1121511900.26101.gz

It also tells us it doesn't find talkback... and I can't see talkback being
built at all in the full log... :(
OK, the error messages of comment #1 were already there when talkback still was
built correctly.

From what I can tell, the regression window is
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&sortby=Date&date=explicit&mindate=1120218600&maxdate=1120234620&cvsroot=%2Fcvsroot

Last correct creature build is 2005-07-01 04:50 (cycle start)
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1120218600.18638.gz

Then we had two red cycles, first failed build is 2005-07-01 09:17 (cycle start)
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1120234620.19084.gz

Note that in the good build, we checked out and built fullsoft (talkback) after
signing NSS libs, in the bad build we don't do that any more and go straight to
building the installer.

As the bustage between the two cycles was bsmedberg's, CCing him.
OK, the bustage there was printing related, but it smells to me like bug 298047
(which is also bsmedberg) could have been a possible cause...
Summary: Talkback doesn't work in seamonkey (rebranding related?) → Talkback doesn't work in seamonkey
Well, it was easy to confirm it being caused by bug 298047 actually, as I was
reminded by reading the bug report that it had been checked in and backed out
again (because of mac bustage) before it was checked in finally.

I looked into the logs of a build made when it was first checked in:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1120084680.18397.gz

And talkback is also missing there.
So it's definately bsmedberg's checkin for bug 298047 which has caused this problem.
Keywords: regression
OS: Linux → All
Hardware: PC → All
Does talkback work for ffox in the same timeframe? We use basically the same
build process so I'm going to be a bit mystified here.

Are we *shipping* talkback and it's just not working, or are we not shipping it
at all? Is it not working in both zip and installer builds, on all platforms?
I'm using zip builds, and talkback is working over there, after you have deleted
compreg.dat once, or opened about:plugins

my latest talkback, attached to Bug 300674:
https://bugzilla.mozilla.org/attachment.cgi?id=189292

Incident ID: 7466175
Stack Signature 	0x00000009 30911087
Product ID 	MozillaTrunk
Build ID 	2005071105
Trigger Time 	2005-07-13 21:07:12.0
Platform 	Win32

Argh. I just realized I was comparing cats to dogs and looked for the cause why
cats don't bark :(

Actually, builds that don't get uploaded as releases don't get talkback built
and are meant to have those talkback packaging errors.

What I'm seeing in my new investigations might really point to rebranding again,
and it might be Linux and Mac only. Sorry. I'll comment when I know more.
OK, I was right with my last comment. Sorry benjamin, I got confused in the
investigation before.

So, actually it _IS_ rebranding being the problem, and it's Linux/Mac only,
Windows is OK.

This is from comet build log for most reecent uploaded build:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1121515980.4749.gz

make -C
/builds/tinderbox/SeaMonkey-Release/Linux_2.4.2-2_Depend/mozilla/fullsoft
fullcircle-push
make: Entering directory
`/builds/tinderbox/SeaMonkey-Release/Linux_2.4.2-2_Depend/mozilla/fullsoft'
rm -f ../dist/bin/mozilla-bin.elf
cp ../dist/bin/mozilla-bin ../dist/bin/mozilla-bin.elf
cp: cannot stat `../dist/bin/mozilla-bin': No such file or directory
make: *** [../dist/bin/mozilla-bin.elf] Error 1
make: Leaving directory
`/builds/tinderbox/SeaMonkey-Release/Linux_2.4.2-2_Depend/mozilla/fullsoft'


This is from barcelona build log for most reecent uploaded build:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1121453700.29933.gz

make -C /builds/tinderbox/Mozilla-Trunk/Darwin_6.8_Depend/mozilla/fullsoft
fullcircle-push
rm -f ../dist/bin/mozilla-bin.elf
cp ../dist/bin/mozilla-bin ../dist/bin/mozilla-bin.elf
cp: ../dist/bin/mozilla-bin: No such file or directory
make: *** [../dist/bin/mozilla-bin.elf] Error 1


note that its looking for mozilla-bin, which doesn't exist any more, it's
seamonkey-bin now.
The make command is called from
http://lxr.mozilla.org/mozilla/source/tools/tinderbox/post-mozilla-rel.pl#190
but I think the error might happen when in the talkback source tree, so I can't
look into that...
Summary: Talkback doesn't work in seamonkey → Talkback doesn't work in seamonkey (due to rebranding)
Whiteboard: happens on Linux and Mac, but not Windows see comment #9 and #10
To answer comment 7:

1)  I'm testing Linux .tar.gz builds.
2)  We're shipping talkback.  It's just not working.

and per comment 8:

3)  Removing compreg.dat does make talkback work here.

So sounds like the usual issue with a bogus compreg.dat shipping.  :(
argh! we should *never* be shipping compreg.dat, that's a bug I fixed and then
it got backed out for reasons I don't quite understand: bug 265492.
Depends on: 265492
(In reply to comment #10)
> cp: cannot stat `../dist/bin/mozilla-bin': No such file or directory
> make: *** [../dist/bin/mozilla-bin.elf] Error 1

This was fixed by Chase in bug 301266 - thanks!

Anyways, I guess we're still shipping the bogus compreg.dat and might still have
a problem due to that, right?
(In reply to comment #13)
> (In reply to comment #10)
 
> Anyways, I guess we're still shipping the bogus compreg.dat and might still have
> a problem due to that, right?

Bug 279993 Talkback not working in non-installer builds after 2005-01-15 because
package contains compreg.dat

3 Workarounds: delete compreg.dat or just open about:plugins or from the Help
menu About Plug-ins
Should this be duped against bug 253750?
This used to work in a timeframe much later than bug 253750.  So this seems like
a new, more recent, problem...
(In reply to comment #16)
> This used to work in a timeframe much later than bug 253750.  So this seems like
> a new, more recent, problem...

It very much looks to me as it's always caused by compreg.dat mismatches (note
that the rebranding-relatzed thing in talkback was fixed in a different bug
report), so it looks this is popping up again and again, as soon as somehow we
get to ship a wrong compreg.dat - maybe the build machines copy new builds over
old ones (or use the same dist/bin again for nwer builds, which may contain an
old compreg.dat) and just need their compreg.dat wiped for it work work again
until the next problem arrives there and it pops up again.
Anyways, it looks to me as if the underlying problem is that we ship a
compreg.dat that might not fit the build (e.g. has no talkback registered) - and
that looks to be the same problem the other mentioned bug reports showed.
With bug 265492 being fixed (which means our packages should be fixed as well),
we might need to update installers to exclude compreg etc. as well, but I hope
we have fixed this bug for packages now.
Could the people doing reular testing and having seen this problem please tell
us if this one is fixed?
With the fixes for bug 301266 and bug 265492 it looks like this has been fixed
for the cases this has been seen in, and we saw no reports of non-working
talkback lately, so I consider this fixed as well.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified.  Thanks, all!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.