Closed
Bug 301004
Opened 19 years ago
Closed 19 years ago
filepicker runs non-modally
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: chpe)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file)
2.83 KB,
patch
|
caillon
:
review+
roc
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Steps to reproduce: 0) Open a page with a <input type=file> in Epiphany 1) Click the Browse button Expected results: The filepicker is modal to the window. Actual result: The filepicker is not modal; you can navigate the window and for example navigate away from the page that showed the filepicker. Patch following.
Assignee | ||
Comment 1•19 years ago
|
||
The window needs to be added to its transient parent's window group.
Assignee: blizzard → chpe
Status: NEW → ASSIGNED
Attachment #189514 -
Flags: superreview?(blizzard)
Attachment #189514 -
Flags: review?(caillon)
Updated•19 years ago
|
Attachment #189514 -
Flags: review?(caillon) → review+
Comment 2•19 years ago
|
||
*** Bug 271816 has been marked as a duplicate of this bug. ***
Comment on attachment 189514 [details] [diff] [review] proposed fix we should land this on trunk for embedders
Attachment #189514 -
Flags: superreview?(blizzard)
Attachment #189514 -
Flags: superreview+
Attachment #189514 -
Flags: approval1.8b4?
Comment 4•19 years ago
|
||
(Note: this is not just an embedding fix, this affects the normal browser's file chooser as well.)
Updated•19 years ago
|
Attachment #189514 -
Flags: approval1.8b4? → approval1.8b4+
Comment 5•19 years ago
|
||
HEAD: Checking in widget/src/gtk2/nsFilePicker.cpp; /cvsroot/mozilla/widget/src/gtk2/nsFilePicker.cpp,v <-- nsFilePicker.cpp new revision: 1.11; previous revision: 1.10 done MOZILLA_1_8_BRANCH: Checking in widget/src/gtk2/nsFilePicker.cpp; /cvsroot/mozilla/widget/src/gtk2/nsFilePicker.cpp,v <-- nsFilePicker.cpp new revision: 1.10.4.1; previous revision: 1.10 done
You need to log in
before you can comment on or make changes to this bug.
Description
•