301005 - Firefox crashes when quitting with multiple modal dialogs open

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[Julien Pervillé]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; fr-FR; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; fr-FR; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

I am able to crash my Firefox 1.0.4 when I attempt to exit while staring at the
cookie listing from within the preference panel.

I noticed the problem since I switched on to disposable cookies for all but the
websites I trust, and I wanted to check if the list got correctly cleared the
first times. By accident I hit Apple-Q to exit and I crashed Firefox. After
reproducing it on purpose, I'm fairly confident this is reproducable, at least
on the OS X platform.

The "bug" shouldnt be too dangerous as it requires an intentional process, and
there is easy work-around (just exit with the window closed!).

Reproducible: Always

Steps to Reproduce:
1. Set cookies preferences to flush on exit.
2. Get some trash cookies browsing sites eg follow links from news.google.com
3. Open the preferences, go to cookie security, and display the cookie list
4. Try to exit : Apple-Q
Actual Results:  
Window disappear (but you can still notice the empty frame of the preference panel).
Then "Application Firefox has crashed" and the talkback agent appears.

Expected Results:  
Just exit :)-

check Talkback crash ID : TB7530372X

Comment 1

[Julien Pervillé]

I will simplify the case :

1/ The bug is triggerable regardless of what cookie mode the user may be. "flush
on exit" or "ask me everytime" does not matter.

1b/ Corrolary is you do not need to have dirty cookies to trigger the crash,
just have the cookie listing open.

2/ I tried to reproduce the bug on other platforms. On Windows I was unable to
trigger it due to the preference windows being modal (no working shortcut to
Quit). This does not mean that the bug is not present on Windows. Linux test coming.

Comment 2

[Julien Pervillé]

More tests :

1/ Does not affect Linux due to use of pseudo-modal boxes.

2/ Does affect Firefox 1.0.5 which I tested quickly

3/ Does not affect Mozilla Suite 1.7.8, quitting from the cookie manager just works.

Comment 3

[Daniel Veditz [:dveditz]]

By "Flush cookies on exit" do you mean the "Keep Cookies: until I close Firefox"
option? I assume that's what you meant, but since you put it in quotes maybe you
mean it literally. If so, have you installed a cookie-managing extension which
might be involved in this bug?

Does it have to be the cookie management screen? Or is it the pref/options
dialog being open in general? (Don't have a mac handy to test)

Sounds similar to old bug 160241 for Camino or bug 183069 for trunk, but those
are both fixed. They were also the preference dialog itself, and you've got both
the pref/options dialog and the cookie viewer dialog open.

Comment 4

[Julien Pervillé]

Attachment: Firefox menu available on the "modal" cookie manager dialog

a screenshot of the cookie window open just before triggering the crash.

please note the availability of the application menu and especially the "Quit
Firefox" option. on all the other firefox platforms I tested, the preference
dialogs are modal, it is never possible to quit from this window.

clicking "Quit" will crash Firefox.

Comment 5

[Julien Pervillé]

You are correct on this old Camino bug, this looks like exactly the same breed
of bug. However this one was fixed long ago and only happened with the
preference pane open. The reason, fix me if I understand wrong, was that Camino
assumed wrongly that there was no more windows and shut down xpcom prematurely.
This time it happens with the cookie dialog open.

Comment 6

[Julien Pervillé]

I tried to check the intuition that the bug happens when you attempt to exit
from a stack of "modal" windows (at least 2 levels deep).

So I attempted to exit from the "saved passwords list" dialog, and triggered the
crash.

This bug is not specific to cookie manager window. Speculation : does it happen
when you stack multiple levels of "modal" preference boxes and attempt to quit
which is not expected to be possible? Then the window count is wrong and
ressource s are fred prematureously (sp), like that Camino bug from long ago.

Comment 7

[Julien Pervillé]

Also happens from within the cookie exception list, and from the advanced plugin
list box

My theory is that :

if ( modalwindow_nesting_level >= 2 && attempted_to_exit() ) then
    crash();
endif

Comment 8

[Laurent Pervillé]

Just tried it on FF 10.0.1 for OSX, bug occurs exactly as described.

Comment 9

[Julien Pervillé]

Spent the afternoon compiling a debug firefox 1.0.5 to play with the bug

Here are the messages in the console at the moment of the crash.
The dashed line marks the moment I triggered the crash from within the cookie
dialog.


++WEBSHELL == 6
++DOMWINDOW == 7
XP Popups: This is a nag to indicate that an inconsistent hack is being done on
the Mac for popups.
WARNING: trying to find screen for sizeless window, using primary monitor, file
/usr/src/mozilla/gfx/src/mac/nsScreenManagerMac.cpp, line 120
frame: DocElementBox(dialog)(-1) (0x3bd5ffc) style: 0x3bd5fd0 {}
Has parent context:  style: 0x3bd5d70 :-moz-canvas {}
Should be null

frame: DocElementBox(dialog)(-1) (0x3bd5ffc) style: 0x3bd5fd0 {}
Has parent context:  style: 0x3bd5d70 :-moz-canvas {}
Should be null

###!!! ASSERTION: Attempt to decrement focus controller's suppression when no
suppression active!
: 'PR_FALSE', file /usr/src/mozilla/dom/src/base/nsFocusController.cpp, line 457
Break: at file /usr/src/mozilla/dom/src/base/nsFocusController.cpp, line 457

------ AT THIS POINT I TRIGGER THE CRASH WITH APPLE-Q FROM THE COOKIE LISTING WINDOW

WARNING: getting z level of unregistered window, file
/usr/src/mozilla/xpfe/appshell/src/nsWindowMediator.cpp, line 636
WARNING: getting z level of unregistered window, file
/usr/src/mozilla/xpfe/appshell/src/nsWindowMediator.cpp, line 636
nsPluginHostImpl::Observe "quit-application"
WARNING: requested removal of nonexistent window
, file
/usr/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,
line 968
--WEBSHELL == 5
--WEBSHELL == 4
--WEBSHELL == 3
./run-mozilla.sh: line 451: 13958 Illegal instruction     "$prog" ${1+"$@"}
yoda:/usr/src/mozilla/ff-test/dist/Firefox.app/Contents/MacOS jeep$ 

Comment 10

[Carsten Book [:Tomcat]]

julien, do you still see this problem in a latest release like Firefox 2.0.0.4 ?

If you still crash, could you provide a Talkback ID (http://kb.mozillazine.org/Talkback)?

Comment 11

[Carsten Book [:Tomcat]]

Closing as INCOMPLETE due to lack of updates. Please reopen if you're still
seeing this issue.

Comment 12

[Julien Pervillé]

Sorry for the delay, my ibook died some months ago, so I had to find someone to investigate for me if the bug is still reproducible.

On Firefox 2.0.x, the bug does not trigger.
I was not able to test on older 1.5 builds.

Sincerely,
Julien Pervillé