301018 - Add INTERFACE section to bug/create/created.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

Bug 289382 introduced an INTERFACE section to bug/create/created.html.tmpl, but
only on the 2.18 branch because it didn't affect the trunk.

The plan is to copy this interface to the 2.20 branch and the trunk.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 189531 [details] [diff] [review]
Patch

>+[%# INTERFACE:
>+  # sentmail: array of hash; bugs for which BugMail should be sent, contains:
...
>+  #     mailrecipients: hash; contains the BugMail recipients, for details on
>+  #         this contents, see template bug/process/bugmail.html.tmpl

On tip, mailrecipients is not in sentmail hash but rather is an individual
variable. Otherwise it's same (except it contains only changer element for
created bugs as documented in the bugmail template).

>+  # bug_list: array of integers; storted bug list (used in template

Nit: typo, sorted not storted (looks like this was on my original patch too).

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1

Comments addressed.

I added mailrecipients to the PROCESS call, too.

Comment 4

[Teemu Mannermaa (:wicked)]

Comment on attachment 190380 [details] [diff] [review]
Patch 1.1

>Index: template/en/default/bug/create/created.html.tmpl
>@@ -32,6 +46,7 @@
...
>+     mailrecipients = mailrecipients

Nit: This is actually not needed because PROCESS allows called template to see
all the variables of the calling template. I tested this change and it seems it
doesn't break things either while making things more explicit.

Otherwise, this looks good to me.

Comment 5

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.9; previous revision: 1.8
done


2.20rc1:

Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.8.10.1; previous revision: 1.8
done