301024 - Classic needs menulist.css for Unix: duplicate menulist dropmarkers

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

We need the same changes like bug 300127 for Thunderbird. Classic still misses
the menulist.css for Unix. With the CSS for win32 we get duplicated dropmarkers.

A patch will follow soon.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Duplicated dropmarkers

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Remove duplicated dropmarker

Ok, this patch removes the duplicated dropmarker. But now, we've another
problem. When an entry is selected and the popup is closed the highlight box
overlays the native dropmarker icon. The label box needs a right-margin or how
it can be cropped on the left side of the dropmarker? How can we obtain the
with of it?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: Updated patch

This will remove the menu-button of the menulist-compact dropmarker. We also
had some overlapping with the native dropdown when selecting an entry from a
menulist. I've changed it to the fix which was checked-in for Thunderbird.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

What I forgot, this patch fixes the unix part of bug 184811.

Comment 5

[[e-mail]]

Comment on attachment 189836 [details] [diff] [review]
Updated patch

Sorry, but the classic theme has to work when native appearance is unavailable
or disabled.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

This could hopefully be fixed with a patch on bug 306987.

Comment 7

[Julien "_FrnchFrgg_" RIVAUD]

neil: It was decided that gnomestripe would depend on native appearance, see bug 412307; This bug WFM here on latest Gecko

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

I don't use Linux at the moment. No idea about the ongoing plans. I'm still can't remember if this bug also covers Thunderbird 2 or doesn't it happen there?

Comment 9

[Julien "_FrnchFrgg_" RIVAUD]

Henrik: Whatever TB2 behaviour is it probably won't change now. TB3 will hopefully use Gecko 1.9 and should get the fix too (I think the fix is in toolkit which is shared and not just part of TB)

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Ok, so lets mark it as WFM as you already stated. I'm interested to see current trunk builds on Linux soon.

Comment 11

[[e-mail]]

(In reply to comment #7)
>Neil: It was decided that gnomestripe would depend on native appearance
Sure, but that doesn't mean that my comment wasn't valid at the time I made it.