Closed
Bug 301048
Opened 19 years ago
Closed 19 years ago
Copying a single bookmark should not append a new line to the end of the URL
Categories
(Firefox :: Bookmarks & History, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha3
People
(Reporter: ispiked, Assigned: ispiked)
References
Details
Attachments
(1 file, 3 obsolete files)
|
1.16 KB,
patch
|
asaf
:
review+
asa
:
approval1.8b5-
asaf
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
When you right click on a bookmark item and copy it, a new line is appended to the end of the URL. Observed this on both Linux and Windows, and in SeaMonkey as well.
|
||
Comment 1•19 years ago
|
||
This was done on purpose so that copying when multiple bookmarks were selected worked properly. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/bookmarks/content/bookmarks.js&mark=460,464#447 However, it probably shouldn't add a new line when only one bookmark is selected.
Assignee: nobody → gavin.sharp
Priority: -- → P3
Hardware: PC → All
Summary: Copying bookmark adds new line to end of URL → Copying a single bookmark should not append a new line to the end of the URL
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
|
Assignee | |
Comment 2•19 years ago
|
||
This removes the last new line when the plain-text format is used, and adds spaces between each link when it's pasted as HTML. Gavin basically figured this one out.
Attachment #189567 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 3•19 years ago
|
||
The real fix.
Attachment #189567 -
Attachment is obsolete: true
Attachment #189568 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189569 -
Flags: review?(mconnor)
|
|
||
Updated•19 years ago
|
Attachment #189568 -
Flags: review?(mconnor)
|
|
||
Updated•19 years ago
|
Attachment #189567 -
Flags: review?(mconnor)
|
|
||
Updated•19 years ago
|
Assignee: gavin.sharp → ispiked
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189569 -
Flags: review?(mconnor) → review?(bugs.mano)
|
|
Assignee | |
Comment 5•19 years ago
|
||
Don't mess with what we add to the end of multiple bookmark HTML pastes.
Attachment #189569 -
Attachment is obsolete: true
Attachment #197897 -
Flags: review?(bugs.mano)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #189569 -
Flags: review?(bugs.mano)
|
||
Comment 6•19 years ago
|
||
Comment on attachment 197897 [details] [diff] [review] just do what I talked about r=mano
Attachment #197897 -
Flags: review?(bugs.mano)
Attachment #197897 -
Flags: review+
Attachment #197897 -
Flags: approval1.8b5?
|
|
||
Comment 8•19 years ago
|
||
Checking in bookmarks.js; /cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v <-- bookmarks.js new revision: 1.110; previous revision: 1.109 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 9•19 years ago
|
||
Comment on attachment 197897 [details] [diff] [review] just do what I talked about we're locking down for beta two and not looking for fixes that aren't for major regressions and topcrashers or security issues.
Attachment #197897 -
Flags: approval1.8b5? → approval1.8b5-
|
|
||
Updated•19 years ago
|
Attachment #197897 -
Flags: approval-branch-1.8.1?(bugs.mano)
|
|
||
Updated•19 years ago
|
Attachment #197897 -
Flags: approval-branch-1.8.1?(bugs.mano) → approval-branch-1.8.1+
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
|
|
||
Comment 10•19 years ago
|
||
mozilla/browser/components/bookmarks/content/bookmarks.js 1.104.2.7
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox1.5 → Firefox 2 alpha3
Version: Trunk → 2.0 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•