301067 - [PostgreSQL] editusers.cgi doesn't do a case-insensitive comparison

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

editusers.cgi says "case-insensitive substring", but PostgreSQL clearly doesn't
do that, see lines 111-121:

            $query .= " $nextCondition profiles.login_name ";
            if ($matchtype eq 'regexp') {
                $query .= $dbh->sql_regexp . ' ?';
                $matchstr = '.' unless $matchstr;
            } elsif ($matchtype eq 'notregexp') {
                $query .= $dbh->sql_not_regexp . ' ?';
                $matchstr = '.' unless $matchstr;
            } else { # substr or unknown
                $query .= 'like ?';
                $matchstr = "%$matchstr%";
            }

This part was missed by bug 285695.

If it's not a performance issue, we could remove the substring part completely
and do a regexp by default, which is really case-insensitive, even in Pg.

Comment 1

[Max Kanat-Alexander]

Hrm. Honestly, I wouldn't particularly mind removing substring searches and
replacing them entirely with regex searches, for this. However, we may have to
add them back in some day if we want to support a DB without a REGEX operator.
(As unlikely *cough*Sybase*cough* as that may be.)

We could also use sql_istrcmp, which would easily solve the problem in this case.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Max Kanat-Alexander]

Comment on attachment 201687 [details] [diff] [review]
patch, v1

Yeah, if you've tested this, this looks right.

Comment 4

[Frédéric Buclin]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.108; previous revision: 1.107
done