301075 - firefox exits when Save button in Save Dialog is clicked

Status: RESOLVED INCOMPLETE

(Toolkit :: Downloads API, defect)

Description

[brock]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

When attempting to download a file from the specified website, the firefox
browser exits when the Save button is clicked. There are no error messages and
no activity from Talkback. The file is not saved. There is no sign of firefox
running when the ps aux command is used.

This is the only site where I have encountered this problem. The thing is, the
website should not be able to cause your browser to close / exit without at
least asking you.

This appears to be happening with this specific web page / URL:

http://www.iron-fe-works.com/pictureclip.asp

I click on the "Click Here To Download" icon near bottom center of page

The status bar shows "javascript:downloader(pictureclip)"

The link launches a small window with a message about the download in it...

The window times out and a save file dialog is displayed with the filename
pictureclip_v2.zip and a file type of Zip archive.

I choose directory to save the file in and click SAVE.

Firefox disappears from existence....  BYE BYE

I don't see the Quality Feedback Agent execute...

I run the ps aux command but there is no trace of firefox in the list.

It is as though Firefox exited normally.

I checked it out on my Windows 98SE machine with Firefox 1.0.4 and it does NOT
occur there. It is limited to Firefox on my Linux system. (Mandrake 10.0)

Reproducible: Always

Steps to Reproduce:
1.Go to http://www.iron-fe-works.com/pictureclip.asp
2.Click on "Click Here To Download" icon near bottom center of page. (The status
bar shows "javascript:downloader(pictureclip)")
3.The link launches a small window with a message regarding the download
4.The window times out and is removed.
5.The Save Dialog is displayed with the filename
6.Choose a directory to save in and click SAVE
7.Firefox disappears from existence.... 
8.There is NO Talkback activity.
9.ps aux shows that Firefox is no longer running.


Actual Results:  
Firefox exited. It did not show up on the list from "ps aux"

The file being downloaded was NOT saved. No partial / temporary file either.

There was NO activity from Talkback.




Expected Results:  
Save dialog box should have closed, Browser should have stayed running, file
should have been downloaded and saved to destination.


Pentium III 1GHz, 512M RAM, Mandrake 10.0

Comment 1

[Aaron Slunt]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050716
Firefox/1.0+ ID:2005071606

Hmm. If you begin the download before the window closes, there's no problem.
However, if you allow the window to automatically close before you click "Ok",
the button gets disabled and the dialog needs to be canceled out of.

I see what problem you might be getting here. If the thing is opening in a new
window, and you let it sit too long, then this problem occurs. I don't
understand why the window is being closed though (I have a different outcome
because I have all opened windows instead open in a new tab).

Should user-triggered pop-ups be allowed to close themselves? That's the
question I have right now. If not, then this might be a valid bug (assuming
there's no dupes). If yes, then there most definitely is a problem, since a file
initially begins downloading before the user gives the ok (it downloads to the
cache, so it's not a security problem if you want to think that).

What's going on here is the window/tab is being closed, thus disabling the
download dialog (and the download, even though it's already began going to the
cache).

Now if the ok to save is given before the closure, then it works out fine. But
that most certainly will not happen many times if the window closes itself like
this.

Comment 2

[brock]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050716
> Firefox/1.0+ ID:2005071606
> 
> Hmm. If you begin the download before the window closes, there's no problem.
> However, if you allow the window to automatically close before you click "Ok",
> the button gets disabled and the dialog needs to be canceled out of.
> 
> I see what problem you might be getting here. If the thing is opening in a new
> window, and you let it sit too long, then this problem occurs. I don't
> understand why the window is being closed though (I have a different outcome
> because I have all opened windows instead open in a new tab).
> 
> Should user-triggered pop-ups be allowed to close themselves? That's the
> question I have right now. If not, then this might be a valid bug (assuming
> there's no dupes). If yes, then there most definitely is a problem, since a file
> initially begins downloading before the user gives the ok (it downloads to the
> cache, so it's not a security problem if you want to think that).
> 
> What's going on here is the window/tab is being closed, thus disabling the
> download dialog (and the download, even though it's already began going to the
> cache).
> 
> Now if the ok to save is given before the closure, then it works out fine. But
> that most certainly will not happen many times if the window closes itself like
> this.

Hmmm.... Couple of things to make sure that my description is complete.

The "thing" is opening in a new window.

Yes, I was letting that window time out. It says that the download will start in
a few seconds so I usually just wait for the Save Dialog to pop up and work on
something else.

I think that a popup (if you allow it) should be able to close itself but not
any other browser window / tab. If it has initiated another dialog, maybe it
shouldn't be allowed to close until the dialog is completed??

However, beyond that, my main Firefox browser had several Tabs open to different
sites that I was working on.

When I say that Firefox Exited, I mean that the main browser window (with all of
the other open tabs) disappeared from the screen. No confirmation that I wanted
to close the other tabs. (I have that option enabled on Firefox to avoid
mistakes...)

I usually work with only one Firefox window and multiple tabs. The exception is
popup windows that are launched by some of the links. Those are usually closed
as soon as they are finished being used.

So, One Firefox Window, Multiple Tabs and the little popup download window that
the website launched was the layout when I experienced the situation.

Hope this helps with the problem definition.

Thanks!

--Brock

Comment 3

[[:Aleksej]]

Thanks for the report.
The bug is almost 2 years old, and the link is now 404.

If the issue is still present, it needs a new link or (better) a testcase.
Closing incomplete for now; please reopen if that requirement is satisfied.