301094 - Duplicated bugmail reasons

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Teemu Mannermaa (:wicked)]

Under some conditions, duplicate bugmail reasons can be generated. Probably has
 (again) something to do with forcing new/old roles to receive bugmail. Don't
know yet whether this affects other things. This might or might not be a
smallish regression from email revamping done some time ago.

For example, following change results in reason duplication (also on
X-Bugzilla-Reason field) on bugmail sent to [e-mail]:

--!--
[e-mail] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|[e-mail]        |bugmaster-
                   |                            |[e-mail]

------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.
You are the QA contact for the bug, or are watching the QA contact.
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.
--!--

Comment 1

[Olav Vitters]

Confirmed. This happens for assignee and QA contact changes. Cause is checking
for these changes twice; Once in process_bug.cgi line 1700-1715. This will
finally set mailrecipients (forcing the qacontact and owner to receive the bug).

The second time assignee/QA contact are forced is within Bugzilla/BugMail.pm,
from line 354-364.

Within BugMail.pm each recipient hash a list of reasons why they are receiving a
bugmail. For the forced assignee/qa contact the list will contain
REL_ASSIGNEE/REL_QA (line 168-174). Later the diffs are checked again. In the
later check it again pushes REL_QA/REL_ASSIGNEE (lines 354-364 as mentioned before).

Eventually a simple foreach on the list (containing the REL_QA/REL_ASSIGNEE
twice) adds the duplicate reasons.

One of these checks seem redundant (don't see why they have to be performed
twice). Suggest to remove the check within process_bug.cgi as BugMail.pm checks
for CC changes (when you are removed from CC list) which process_bug.cgi does not.

Comment 2

[Teemu Mannermaa (:wicked)]

Looks like this is fixed by the blocker patch.