301107 - Items in autocomplete and history popups don't line up vertically

Status: NEW

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

If you start typing in the url bar, suggested url's in the autocomplete popup
doesn't have the same left margin as the url's in the history popup.

Comment 1

[Stefan [:stefanh]]

Attachment: Patch for win/nix just to demonstrate how it would look

Just attaching a patch to demonstrate how it would look on win/nix.

Comment 2

[[e-mail]]

Can you do me some screenshots to show me what you mean? Thanks.

Comment 3

[Stefan [:stefanh]]

Attachment: screenshots of drop-downs in url bar

(In reply to comment #2)
> Can you do me some screenshots to show me what you mean? Thanks.

Sure :)

Note that those are mac-screenshots, and there's more stuff to correct (like
the background-color on the hovered menuitem in the history-drop-down (mac os 9
colors...). I thought of fixing the mac stuff in bug 301105, leaving this bug
only for win/nix.

What you can see in the screenshots that I wanted to correct here (I checked
with people and it seems to appear on win/nix as well) is:

1) Different height on items in the two boxes (the effect is that you think
that the line-height differ between the two drop-downs)

2) Different left-margin on items in autocomplete, history and search box.

Comment 4

[[e-mail]]

Comment on attachment 189621 [details]
screenshots of drop-downs in url bar

You're missing the [G] icon from the Search Google line. Perhaps you don't have
a new enough build with ajschult's patch.

I also see you've got a spurious border between autocomplete and search, which
I don't see on Windows or Linux.

Although I see why you would want to line up the text of each popup with the
URL bar I'm not so convinced about the line height. It's probably harder as
there are font metrics to account for.

You might find it easier to fix Modern first ;-)

Comment 5

[Stefan [:stefanh]]

> You're missing the [G] icon from the Search Google line. Perhaps you don't have
> a new enough build with ajschult's patch.

Ah, yes. Missed that...

> Although I see why you would want to line up the text of each popup with the
> URL bar I'm not so convinced about the line height. It's probably harder as
> there are font metrics to account for.
>

There's a min-height on the tree rows in tree.css that thought I could use on
the menuitems:
 
 .autocomplete-history-popup > menuitem {
   max-width: none !important;
+  min-height: 18px;
+  padding: 0px 2px 0px 2px;
   font: message-box

In tree.css:

treechildren::-moz-tree-row {
 border: 1px solid transparent;
 background-color: transparent;
 min-height: 18px;
 height: 1.3em;


> You might find it easier to fix Modern first ;-)
> 

Good point ;)

Comment 6

[Wayne Mery (:wsmwk)]

FF has same problem of course