301147 - EM/TM doesn't check compatibility anymore (previously disabled incompatible extensions/themes now enabled)

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Bastian Grupe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050717 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050717 Firefox/1.0+

Previously installed and marked incompatible extensions and themes are no longer
marked incompatible (and screw up things).

This regressed about the time of DPA2 release, in fact shortly after it (1 or 2
nightly builds). I was using the AUS to update it.

Reproducible: Didn't try

Steps to Reproduce:
1. Install a trunk version between DPA1 and DPA2
2. install incompatible extensions and themes (Qute 3, Grease monkey etc)
3. update FF using AUS to the latest nightly

Actual Results:  
Incompatible extensions and themes are loaded.

Expected Results:  
Incompatible extensions or themes should be disabled.

I have previously shared the profile between 1.1 and 1.0.x (by accident) and it
*could* be some late fallout.

*BUT* the EM seems to ignore all compatibility checks altogether, changin the
last version from 1.0+ to 1.0 doesn't make it check for compatibility.

Comment 1

[Robert Strong (they/them - no direct email)]

(In reply to comment #0)
> Steps to Reproduce:
> 1. Install a trunk version between DPA1 and DPA2
> 2. install incompatible extensions and themes (Qute 3, Grease monkey etc)
> 3. update FF using AUS to the latest nightly
Not sure how to accomplish step 2 with a DPA1 build. DPA1 has an
app.extensions.version = 1.0+ the same as DPA2 so an extension that is
considered compatible or incompatible by DPA1's criteria is exactly the same as
DPA2. Also, trying to install an incompatible extension with the EM using DPA1
displays the can't install because it is incompatible message. Can you provide
the exact steps you used to install an incompatible extension?

Comment 2

[Bastian Grupe]

I just realized what caused it:

I backupped my deer park profile, used 1.0.x once (marking the exts compatible),
then restored my old profile (marking them as not to check) so it never again
checked for compatiblity (unless I deactivated them manually).

Marking it invalid since it should not happen in real world use.