30116 - Can lose window if minimize and then shut down

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P1)

Description

[Paul MacQuiddy]

I found an easily reproducible case where if you minimize a window you can
'lose' it after shuttting down and re-starting. I have seen this a lot and other
people have seen it too.

To reproduce:

1. Launch mozilla (I have browser and mail come up on launch)
2. Minimize mail
3. Shut down from browser menu using File - Quit.
4. Launch again.

Results: Browser window comes up okay, mail window comes up minimized, and *does
not* open when you click on it in the system tray. The only way to open it is
via a right click and selecting maximize, which is a semi-advanced move.

Expected Results: We should not remember the minimized state on launch, and even
if we did remember it, it should open up when you click on it in the system tray.

Found on win98, unable to reproduce on linux or mac.

Comment 1

[Paul MacQuiddy]

Marking beta1, since this could cause people to lose functionality in mail (or
browser if they did it the other way around).

Comment 2

[lchiang]

possibly related to http://bugzilla.mozilla.org/show_bug.cgi?id=29027 which 
Laurel filed a while back.

Comment 3

[Phil Peterson]

[PDT+] w/b minus on 3/10

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think what happens is that mozilla saves the window-size and position every 
time a window is moved or resized. This is probobly done even when the resize 
is a minimize or maximize action.
So if you minimize a window and then open a new window (restarting or open new 
window from another window) the window will get the size and position of a 
minimized window, as "restored" size!

This is also the reason that mozilla-windows are opened at maximum size but not 
maximized.

Comment 5

[Chris Waterson]

paulmac: I'm tempted to say that this is really just a dup of 26834. Whatdya 
think? (Solving 26834 will certainly "fix" this bug.)

Comment 6

[Chris Waterson]

hey danm, should we also remember "minimized" and "maximized" state as part of 
the window's size? Could/should we use special values of x/y/width/height to 
indicate this? Or use another attribute?

Comment 7

[Paul MacQuiddy]

Waterson, feel free to mark this as a dup.

Although you didn't ask me, I think we should remember maximized, but *not*
remember minimized (at least we didn't in 4.x that I know of).

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Just so you don't miss it: It is not enough to remember just that the window is 
maximized, you also have to remember what size it should get once the maximized 
window is "restored".

One other thing that also needs some working on is that currently newly opened 
window overlapps the current window EXACLY. New windows should have the same 
size as the old window, but be "cascaded" (a bit lower and a bit to the right).
Don't know if this should be filed a new bug, but it seems that this should go 
into the same piece of code as the current bugreport.

Comment 9

[Chris Waterson]

to danm...all star window maximizer position daddy.

Comment 10

[Paul MacQuiddy]

*** Bug 30604 has been marked as a duplicate of this bug. ***

Comment 11

[Peter Trudelle]

Agree that we should not remember minimized state.  Is this case covered by
26834? Also, subsequent cascading windows should only be as big as the first if
they can still fit entirely on the screen.  cc saari.

Comment 12

[saari (gone)]

I can open the minimized mail window via the window controls (maximize, drag an 
edge, etc). The window is already up when you open mail the second time, it just 
doesn't have any content area, just the title bar. 

So the only bug is persisting minimized size, everything else works.

Comment 13

[Dan M]

  Windows and Mac no longer persist window size when maximized or minimized, as 
applicable. Gtk never has persisted an iconified size, and, correct me if I'm 
wrong, allows no real way to tell whether it's in a maximized state, so it 
continues to persist its size when maximized.
  So gtk seems unfixable, and besides, this was a Windows bug. Calling it fixed.

Comment 14

[Tom Everingham]

verified:
Win 98 2000031009

Comment 15

[Dan M]

(Note to sicking: the window is saving its maximized/minimized state, but it's 
not restoring to it yet. That'll come later. And yes, new windows aren't created 
offset from their originator. I think that's the subject of another bug, though I 
can't cite a number. Anyway, it's well-known.)