Closed Bug 301219 Opened 19 years ago Closed 19 years ago

Remove rm hack from glue Makefile

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.8beta4

People

(Reporter: Biesinger, Assigned: Biesinger)

References

(
URL
)

Details

Attachments

(1 file)

patch
552 bytes, patch
benjamin
: review+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review 
That hack seems to be not quite working anyway - it tries to remove stuff in the
srcdir.
Attached patch patch — — Splinter Review 

  

  



        Attachment #189690 -
        Flags: review?(benjamin)

    
  

        Attachment #189690 -
        Flags: review?(benjamin)

        Attachment #189690 -
        Flags: review+

        Attachment #189690 -
        Flags: approval1.8b4+

    
    

    
  
Checking in Makefile.in;
/cvsroot/mozilla/xpcom/glue/Makefile.in,v  <--  Makefile.in
new revision: 1.28; previous revision: 1.27
done

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4

    
    

    
  
Just to clear up the apparent confusion, that *was* the point of the hack.  One
version of xpcom/glue/standalone/Makefile.in was putting objs in the glue/
srcdir even during an objdir build.  We added the hack so that we didn't have to
manually touch every objdir tinderbox. 

  

  


Status: RESOLVED → VERIFIED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: