301225 - jsDriver.pl doesn't deal with tests with relative paths

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I mentioned this problem to Bob on IRC the other day, where a shell.js wasn't
being run properly. At the time, I (sort of) incorrectly blamed the code in
jsDriver.pl that appends the "-f path/of/shell.js" to the commandline.

In reality, the problem was that I'd generated my test list with a "find"
command which had created the list in the form of: ./ecma_3/RegExp/15.10.2-1.js.
Note the leading "./" which confused the jsDriver.pl code that simply does a
split() on the test. I have a very simple fix to avoid this sort of problem
(that I'll attach) but I also wonder if I should just extend the code to execute
an arbitrary number of shell.js files in the path to the test (so if we wanted,
we could have test with arbitrary nesting). I guess that's Bob's call.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: easy patch

Bob, what do you think of this? It simply strips off an arbitrary number of ./
and ../ from the beginning of the test path (a bad side effect of this simple
patch is that it'd become impossible to specify relative test paths. But that's
broken anyway now. Do we want to support that?).

Comment 2

[Bob Clary [:bc] (inactive)]

What is the usecase here? Using |find| to generate a list of tests? 

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Yeah. I couldn't find an easier way to just run one directory of the test suite
(in this case RegExp, though I've used it for Array, too).

Comment 4

[Bob Clary [:bc] (inactive)]

sorry, comment 0 answered my question. I need to read more. 

Won't perl jsDriver.pl -l ecma/Array -e smopt -s ../src/WINNT5.1_OPT.OBJ/js.exe
do what you want?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Apparently -l does what I want without even generating a file! Marking WONTFIX.