301318 - Initial focus in help

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Aaron Leventhal]

Currently the initial focus goes to the content pane.

The only problem with this is that as a screen reader user, one will typically
use tab to go through all the elements in a dialog to see what is there.

When you tab through you just see links. This will usually lead to the
impression that the content pane is all that there is in the dialog.

I recommend starting initial focus in the first field -- quick search. This is a
more useful place anyway. I'm not generally going to be reading "welcome to deer
park alpha 2". Maybe once.

Comment 1

[Aaron Leventhal]

Mike, can you comment on whether it is okay with you to change this?

Comment 2

[Mike Connor [:mconnor]]

Yeah, let's do it.

Comment 3

[Aaron Leventhal]

Attachment: Set initial after first content loads because loading the content resets the focus

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 189855 [details] [diff] [review]
Set initial after first content loads because loading the content resets the focus

>? q.bat
>? content/q
>Index: content/help.js
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/components/help/content/help.js,v
>retrieving revision 1.33
>diff -p -u -5 -r1.33 help.js
>--- content/help.js	7 Jul 2005 19:30:09 -0000	1.33
>+++ content/help.js	20 Jul 2005 02:07:54 -0000
>@@ -527,10 +528,13 @@ nsHelpStatusHandler.prototype = {
>           this.throbberElement.setAttribute("busy", "true");
>       } else if (aStateFlags & nsIWebProgressListener.STATE_STOP) {
>         if (aRequest && this.throbberElement) {
>           this.throbberElement.removeAttribute("busy");
>         }
>+        if (!document.commandDispatcher.focusedElement) {
>+          focusSearch();  // no focus in window yet, so set initial focus to search field
>+        }

r+a=me, but it'd be great if you could remove the previous if block, and
basically all of the references to this.throbberElement ;)  If not, please just
file a follow on me to clean that up.

Comment 5

[Aaron Leventhal]

Checking in content/help.js;
/cvsroot/mozilla/toolkit/components/help/content/help.js,v  <--  help.js
new revision: 1.34; previous revision: 1.33
done

Comment 6

[Caleb]

Aaron, what's with all the removed code in the patch you checked in?
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/components/help/content&command=DIFF_FRAMESET&file=help.js&rev1=1.33&rev2=1.34&root=/cvsroot

The patch you posted here only adds 3 lines, the patch that was checked in
(judging from that cvs diff) removes all kinds of stuff, and probably broke the
back/forward buttons in the help viewer!

Comment 7

[Caleb]

Oh, I didn't notice comment 4.

Anyway, I think that the code you removed caused bug 302111.