narcissus doesn't build on windows because mrbkap entrailed a js private function (js_GetDependentStringChars) using a js macro (JSSTRING_CHARS) in jsshell (Evaluate) which is an embedding consumer.
Status: NEW → ASSIGNED
Created attachment 189807 [details] [diff] [review] use public apis timeless was concerned about JS_GetStringChars returning NULL, but I don't think that source can be a dependent string, so JS_GetStringChars shouldn't need to allocate anything and we should be safe.
Attachment #189807 - Flags: review?(brendan)
Comment on attachment 189807 [details] [diff] [review] use public apis Brendan says r=him.
Attachment #189807 - Flags: review?(brendan) → review+
Furthermore (timeless!), JS_GetStringChars never returns null. If there's an OOM it returns a pointer into the dependent string's base string's chars, which lacks only a NUL backstop terminator. /be
Comment on attachment 189807 [details] [diff] [review] use public apis So this is not part of the build (unlike xpcshell), but a=me anyway -- get it in so we can all move on ;-). /be
Attachment #189807 - Flags: approval1.8b4+
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.