js.obj : error LNK2019: unresolved external symbol _js_GetDependentStringChars referenced in function _Evaluate

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: timeless, Assigned: mrbkap)

Tracking

Trunk
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
narcissus doesn't build on windows because mrbkap entrailed a js private
function (js_GetDependentStringChars) using a js macro (JSSTRING_CHARS) in
jsshell (Evaluate) which is an embedding consumer.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

13 years ago
Created attachment 189807 [details] [diff] [review]
use public apis

timeless was concerned about JS_GetStringChars returning NULL, but I don't
think that source can be a dependent string, so JS_GetStringChars shouldn't
need to allocate anything and we should be safe.
(Assignee)

Updated

13 years ago
Attachment #189807 - Flags: review?(brendan)
(Assignee)

Comment 2

13 years ago
Comment on attachment 189807 [details] [diff] [review]
use public apis

Brendan says r=him.
Attachment #189807 - Flags: review?(brendan) → review+
Furthermore (timeless!), JS_GetStringChars never returns null.  If there's an
OOM it returns a pointer into the dependent string's base string's chars, which
lacks only a NUL backstop terminator.

/be
Comment on attachment 189807 [details] [diff] [review]
use public apis

So this is not part of the build (unlike xpcshell), but a=me anyway -- get it
in so we can all move on ;-).

/be
Attachment #189807 - Flags: approval1.8b4+
(Assignee)

Comment 5

13 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Flags: testcase-
You need to log in before you can comment on or make changes to this bug.