Closed
Bug 301341
Opened 19 years ago
Closed 19 years ago
make building narcissus w/ Makefile.ref easier
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
421 bytes,
patch
|
mrbkap
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
currently you have to abuse *C*FLAGS or similar creatures
|
||
Comment 2•19 years ago
|
||
Comment on attachment 189808 [details] [diff] [review] support make -f Makefile.ref NARCISSUS=1 r=me. Brendan, how about a second stamp of approval.
Attachment #189808 -
Flags: superreview?(brendan)
Attachment #189808 -
Flags: review+
|
||
Comment 3•19 years ago
|
||
Comment on attachment 189808 [details] [diff] [review] support make -f Makefile.ref NARCISSUS=1 Ok, but no need for the =1 in the option, -DFOO defines FOO to 1. /be
Attachment #189808 -
Flags: superreview?(brendan) → superreview+
|
||
Updated•19 years ago
|
Flags: testcase-
Summary: make building narcissus w/ Makefile.ref easier → make building narcissus w/ Makefile.ref easier
|
||
Comment 4•19 years ago
|
||
The patch was checked in on 2005-12-21.
Status: NEW → RESOLVED
Closed: 19 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•