301346 - change jsDriver.pl to use system instead of open for executing js shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

I have been having problems running jsDriver on WinXPSP2 for a couple of weeks.
It may be a problem with unix/dos line endings in perl/cygwin and msvc file
output. Changing the open(OUTPUT, "foo args |"); @output = <OUTPUT>; close
OUTPUT; to use system and a temp file.

patch coming up

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 189811 [details] [diff] [review]
patch

Ain't it fun working around bugs in Perl? ;-)

r=me with the tabs you've introduced changed into spaces.

Comment 3

[Bob Clary [:bc] (inactive)]

Checking in jsDriver.pl;
/cvsroot/mozilla/js/tests/jsDriver.pl,v  <--  jsDriver.pl
new revision: 1.57; previous revision: 1.56

thx

Comment 4

[Bob Clary [:bc] (inactive)]

I checked in a minor change 

-        system "$command $redirect_command > js.out";
+        system "$command > js.out $redirect_command";

to fix the stderr to stdout duplication.

Checking in jsDriver.pl;
/cvsroot/mozilla/js/tests/jsDriver.pl,v  <--  jsDriver.pl
new revision: 1.58; previous revision: 1.57