301350 - Mac OS X Updater shows the wrong String

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Scott MacGregor]

When I do a Thunderbird update on Mac OS X. The updater dialog that comes up
refers to Firefox and not Thunderbird. 

"Applying updates to Firefox.  Please do not interrupt this process."

Even though we have the right updater.ini file in the application package. That
file shows the right string, but the string we actually show in the UI says
Firefox. I'm not sure why that is.

Comment 1

[Asaf Romano (gone)]

Maybe move the NIB file(s?) into the app level?

Comment 2

[Darin Fisher]

This is pretty odd.  I guess the Cocoa calls aren't working properly.  Pointer
to the code:
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/updater/progressui_osx.mm#72

Josh: can you help with this bug?

Comment 3

[Josh Aas]

I'll take a look tonight.

Comment 4

[Josh Aas]

The problem isn't the cocoa calls - they work fine, as you can see with Firefox.

The problem seems to be that in Deer Park, you copy
"DeerPark.app/Contents/MacOS/updater.ini" into the updater.app bundle that goes
in "DeerPark.app/Contents/MacOS/updates/0/". You're not doing that in
Thunderbird, so updater.ini isn't being found, and the default nib strings are
showing up. The defaults have "Firefox" in them.

I'll leave it up to you to sort out how you want to fix this since it'll
probably be easy now that you know that. I recommend that you change the default
strings in the nib (in the content area and the title) to something like
"default string" so that it is obvious when you can't find updater.ini, instead
of fooling you into thinking it is setting strings with "Firefox" in them.

Comment 5

[Darin Fisher]

Attachment: v1 patch

I haven't tested this patch, but I believe it should do the trick.  This is
just copy paste from browser/locale/Makefile.in.  My fault for not applying
this change to mail/locale/Makefile.in back when I made the change for firefox.


Can someone please help verify this fix?

Comment 6

[Darin Fisher]

Josh: I don't have time to update the nib file.  If you could help with that,
it'd be greatly appreciated.  Otherwise, I think my patch here is sufficient
(provided it works).

Comment 7

[Scott MacGregor]

Comment on attachment 190080 [details] [diff] [review]
v1 patch

looks pretty straightforward to me.

Comment 8

[Josh Aas]

I checked in more obvious default strings for the nib earlier today, a=asa

Comment 9

[Darin Fisher]

fixed-on-trunk