Closed Bug 301352 Opened 19 years ago Closed 19 years ago

Broken Search Messages Dialog

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: mscott, Assigned: mscott)

Details

Attachments

(1 file)

the fix
1.42 KB, patch
Bienvenu
: superreview+
asa
: approval1.8b4+
Details | Diff | Splinter Review 
7/19 Builds.

1) Select a virtual folder.
2) Edit / Find  / Search Messages

Note the broken dialog with out any search criteria rows

JS error:

Error: firstItem has no properties
 Source File: chrome://messenger/content/SearchDialog.js
 Line: 355

This is triggered because we try to select a virtual folder and fail.
Status: NEW → ASSIGNED
Summary: Broken Search Messages Dialog → Broken Search Messages Dialog
Target Milestone: --- → Thunderbird1.1
I think this regression was caused by Bug 301352 when we changed the folder
picker in the search dialog to be a flat list.
Attached patch the fix — — Splinter Review 
David, this fixes our folder picking logic in the Search Dialog when our
current selected folder in the 3-pane is not searchable. This logic broke when
we moved to our new widget for picking the folder to search in the search
messages dialog.
Attachment #189828 - Flags: superreview?(bienvenu)
Attachment #189828 - Flags: approval1.8b4?
Attachment #189828 - Flags: superreview?(bienvenu) → superreview+
Attachment #189828 - Flags: approval1.8b4? → approval1.8b4+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Good catch; when I wrote the new widget all my folders were searchable...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: